large merge of master into multinode, including multiple fixes for tests etc #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d some TODOs to be addressed
|
@sanchit-misra @hyeok9855 @saleml This is now ready to review. I realize the size of this PR is so large that it's not really practical to review, but I wanted to give you all the opportunity (and I need one of you to approve). I'll verify all tests pass in the AM tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I'm trying to update the multinode branch to match master, but I've uncovered a few big outstanding issues, which can be found as the TOODs in
test_scripts.py.For example:
torchgfn/tutorials/examples/test_scripts.py
Line 108 in c5b7ffa
This appears to be due to a design flaw in
StatePairs. To be discussed during our standup tomorrow.