Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to export vertices list to temp layer #198

Merged
merged 13 commits into from
Dec 21, 2023
Merged

Add option to export vertices list to temp layer #198

merged 13 commits into from
Dec 21, 2023

Conversation

merydian
Copy link
Collaborator

No description provided.

koebi
koebi requested changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@koebi koebi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation is missing - I'll add that, once the tooltip fits.

This seems to give me the option to select a CRS, but the saved layer is always EPSG:4326?
In addition, clicking "Cancel" doesn't cancel, but still saves the vertices.

ORStools/gui/ORStoolsDialogUI.py Outdated Show resolved Hide resolved
ORStools/gui/ORStoolsDialogUI.ui Outdated Show resolved Hide resolved
ORStools/gui/ORStoolsDialogUI.ui Outdated Show resolved Hide resolved
@koebi koebi force-pushed the add-option-to-export-centroid-list-to-layer branch from b4f1fee to bfaf3ee Compare December 11, 2023 09:50
@koebi koebi added this to the Version 1.7 milestone Dec 15, 2023
koebi
koebi requested changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@koebi koebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this looks good in general, maybe we should either give feedback that saving has worked (there's this very QGIS way using the "messages bar", where errors pop up) or ask the user for a name or something, to make them aware that sth happened?

ORStools/gui/ORStoolsDialog.py Outdated Show resolved Hide resolved
@koebi koebi force-pushed the add-option-to-export-centroid-list-to-layer branch from 17eabfd to 121434b Compare December 21, 2023 11:09
@koebi
fix: re-add epsg to VectorLayer
e8f445f 
This probably got lost in a rebase and is now re-applied
@koebi koebi force-pushed the add-option-to-export-centroid-list-to-layer branch from 21a5338 to e8f445f Compare December 21, 2023 11:19
@koebi koebi marked this pull request as ready for review December 21, 2023 14:43
@koebi koebi merged commit 4b05e86 into main Dec 21, 2023
2 checks passed
@koebi koebi deleted the add-option-to-export-centroid-list-to-layer branch December 21, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koebi koebi koebi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 1.7
Development

Successfully merging this pull request may close these issues.
2 participants
@merydian @koebi