Prepare icon and UI imports for qt6 QGis builds #250
Conversation
There was a problem hiding this comment.
Why does this whole file change? I assume b/c of line endings?
There was a problem hiding this comment.
Is the license of this compatible with ours?
There was a problem hiding this comment.
We are importing a rather large chunk of code here, of which only 3 small functions are used.
I suggest to reduce the import to the functions in question.
| if not os.path.exists(path): | ||
| return path | ||
|
|
||
| return path |
There was a problem hiding this comment.
This branching is essentially useless?
ORStools/utils/gui.py
Outdated
| path = os.path.join( | ||
| os.path.dirname(__file__), | ||
| '..', | ||
| 'gui', | ||
| file) |
There was a problem hiding this comment.
This is highly dependent on the code layout of the plugin - in our case, it works, but it feels way more generic than it is?
| return QIcon(path) | ||
|
|
||
| @staticmethod | ||
| def get_icon_svg(icon: str) -> str: |
There was a problem hiding this comment.
While this reads like it should do something with svg, the code does nothing - and rather has the functionality I'd expect in get_icon.
There was a problem hiding this comment.
I'd like more context on the deletion of this file.
There was a problem hiding this comment.
I'd like more context on the deletion of this file.
No description provided.