Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating deployment code and adding tests #6

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Updating deployment code and adding tests #6

merged 2 commits into from
Dec 27, 2023

Conversation

OpenGLShaders
Copy link
Contributor

@OpenGLShaders OpenGLShaders commented Dec 26, 2023 •
edited
Loading

  • Added tests to resource and data source
  • Found a bunch of bugs in deployment code

Deployment code is not complete yet, waiting on cluster resource to be finished before I can finalize deployment code.

@OpenGLShaders OpenGLShaders self-assigned this Dec 27, 2023
ikegentz
ikegentz approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@ikegentz ikegentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests worked great!

@OpenGLShaders OpenGLShaders merged commit 88047e1 into main Dec 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikegentz ikegentz ikegentz approved these changes

Assignees

@OpenGLShaders OpenGLShaders

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OpenGLShaders @ikegentz