Test for LENS / SOAP / tSOAP #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Final parameters: The rtol for tSOAP can be smaller than E-11 but we already have a very low tolerance so i think that will not be a problem for possible code modifications |
andrewtarzia
requested changes
Mar 15, 2024
andrewtarzia
requested changes
Mar 18, 2024
|
All required changes should have been done. |
|
@SimoneMartino98 please do not resolve conversations in PRs. It is up to the reviewer to do so after they deem it complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues:
Requested Reviewers: @andrewtarzia
Note for Reviewers: If you accept the review request add a 👍 to this post