Solving issues in the onion examples #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewtarzia
approved these changes
Nov 25, 2024
andrewtarzia
approved these changes
Nov 25, 2024
andrewtarzia
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested Reviewers: @andrewtarzia
The way one hat to import every function is ugly, though. Maybe @andrewtarzia knows why the cleanest way (importing the needed function in the preamble) does not work. Anyway, I think it's better to PR the working code, so that people can use it, and then we make it cleaner if possible. Unless it's a quick fix.
The new code was tested by running the examples, which produced the correct output.
just fixandjust checkare also happy with the code.