New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced all the array_equal with all_close to avoid numerical precision issues #67

Merged

andrewtarzia merged 1 commit into GMPavanLab:main from SimoneMartino98:num_precision

Feb 18, 2025

Contributor

SimoneMartino98 commented Feb 18, 2025

Hi @andrewtarzia and @matteobecchi;

This PR aims to avoid issues with numerical precision when comparing expected and tested arrays in tests.

I have replaced all the instances of assert np.array_equal(...) to assert np.allclose(...)


          replaced all the array_equal with all_close

67ee436

andrewtarzia approved these changes

View reviewed changes

Contributor

matteobecchi commented Feb 18, 2025

You have my approval

andrewtarzia merged commit 06d0766 into GMPavanLab:main

11 checks passed

SimoneMartino98 deleted the num_precision branch

February 18, 2025 15:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet