Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Phil Dominguez <142051477+phildominguez-gsa@users.noreply.github.com>
  • Loading branch information
danswick and phildominguez-gsa authored Mar 18, 2024
1 parent 46e3b0a commit cffb3e5
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
14 changes: 7 additions & 7 deletions src/api/rollups.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ rollups:
rolled: QCOSTS
orig: QCOSTS from Findings table
criteria: "If any of the auditee's findings have QCOSTS = Y (QCOSTS from Findings Table)"
output: Then QCOSTS in General table = Y otherwise QCOSTS = N
censusdesc: Indicate whether or not the audit disclosed any known questioned costs.
output: Then QCOSTS in General table = Y, otherwise QCOSTS = N
censusdesc: Indicate whether or not the audit disclosed any known questioned costs
code: https://github.com/GSA-TTS/fac-api-examples/tree/main/rollups/03-qcosts
CYFINDINGS:
rolled: CYFINDINGS
orig: Findings Table
criteria: If any records in the Findings table
output: "CYFINDINGS=Y"
output: "CYFINDINGS = Y"
censusdesc: >
Indicate whether or not current year findings affecting direct funds were reported
code: https://github.com/GSA-TTS/fac-api-examples/tree/main/rollups/04-cyfindings
Expand All @@ -39,7 +39,7 @@ rollups:
orig: TYPEREPORT_MP from CFDA (now `federal_awards`) table
criteria: Combines all values (U, D, A, S) entered in the TYPEREPORT_MP field from CFDA
output: >
"U" if all TYPEREPORT_MP = U or the non-"U" values listed once
"U" if all TYPEREPORT_MP = U, otherwise all non-U values listed once
censusdesc: Type of report issued on the major program compliance
code: https://github.com/GSA-TTS/fac-api-examples/tree/main/rollups/050-typereportmp
MATERIALWEAKNESS_MP:
Expand All @@ -62,7 +62,7 @@ rollups:
rolled: PYSCHEDULE
orig: Question 3.d. on the Audit Info tab
criteria: If there is any number other than 00 listed
output: PYSCHEDULE=Y
output: PYSCHEDULE = Y
censusdesc: >
Indicate whether or not the report includes a Summary Schedule of Prior Year Audit Findings
code: https://github.com/GSA-TTS/fac-api-examples/tree/main/rollups/08-pysched
Expand Down Expand Up @@ -320,14 +320,14 @@ In the Python example provided, you can do this by converting the list to a set,

```python
# If there is any number other than 00 listed
# Then PYSCHEDULE=Y
# Then PYSCHEDULE = Y
set_of_agencies = set()
for find in json:
numbers = list(filter(lambda n: n != "00",
[n.strip() for n in find[AWPF].split(',')]
))
set_of_agencies.update(numbers)
# An empty set is "false" in python
# An empty set is "false" in Python
return bool(set_of_agencies)
```

Expand Down
4 changes: 2 additions & 2 deletions src/api/tribal.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ meta:

Tribes and Tribal organizations have the option, per [2 CFR 200.512(b)(2)](https://www.ecfr.gov/current/title-2/part-200/subpart-F#p-200.512(b)(2)), to suppress their Single Audit data.

For Tribes and Tribal organizations who choose to protect their data, the API will show is_public in the /general endpoint set to False.
For Tribes and Tribal organizations who choose to protect their data, the API will show `is_public` in the `/general` endpoint set to `False`.

If you believe you should have access to these audits, you will need to request a copy of the Tribal API Access Agreement via the [helpdesk](https://support.fac.gov/hc/en-us).

Expand Down Expand Up @@ -116,7 +116,7 @@ Once you have the access information, you can use it to download the associated

#### Parameters

`access_uuid (required)`: The access UUID obtained from the request_file_access endpoint.
`access_uuid (required)`: The access UUID obtained from the `/request_file_access` endpoint.

#### Headers

Expand Down

0 comments on commit cffb3e5

Please sign in to comment.