Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource Pages, Home Page, and Header Updates #91

Merged
merged 85 commits into from
Mar 19, 2024
Merged

Resource Pages, Home Page, and Header Updates #91

merged 85 commits into from
Mar 19, 2024

Conversation

lauraherring
Copy link
Contributor

@lauraherring lauraherring commented Mar 6, 2024 •
edited by danswick
Loading

related issue: GSA-TTS/FAC#3369

This PR covers a lot of significant changes to the static site. Most notable are:

jperson1 and others added 30 commits February 7, 2024 16:19
@jperson1
New resource pages - initial commit
9883958
@lauraherring
updating submission resources hub
244787b
@lauraherring
adding submission guide card
369a68f
@lauraherring
fixing links on cards
5724983
@lauraherring
link experimenting
ccc1e67
@lauraherring
link again
4107d81
@lauraherring
more link poking
9171f56
@lauraherring
another link attempt
935cc37
@lauraherring
link desperation
5d35138
@lauraherring
adding additional cards
b264d93
@lauraherring
links again
c00c444
@jperson1
Utilize baseUrl, no slashes at the front of card links
04a30db
@jperson1
Merge remote-tracking branch 'refs/remotes/origin/jp/resource-pages' …
ccdab43 
…into jp/resource-pages
@jperson1
Link to the FAQ page
d0f8a1a
@lauraherring
adding the rest of the links
70ac604
@lauraherring
fixing URLs
9fa46a2
@lauraherring
search resources hub updates
28c63e8
@jperson1
Seaprate FAQ links
8ff4b42
@jperson1
Merge remote-tracking branch 'refs/remotes/origin/jp/resource-pages' …
dd02b6e 
…into jp/resource-pages
@lauraherring
adding FAQ links
92545e1
@jperson1
Res. page descriptions -> content. Margins & fonts
dbe7b64
@jperson1
A reasonable first pass at home and header updates
2b33f2b
@jperson1
Different URL for img, forward usa-icon for svg
56d0bd9
@jperson1
Manually include the sprite cache
e3ae258
@jperson1
Utilize baseUrl in SVG icon imports
847ba85
@lauraherring
updating global nav titles
15ffe70
@lauraherring
navigation changes
563b402
@lauraherring
moving pages for navigation
24bb3c2
@lauraherring
updating search urls
bcf9975
@lauraherring
audit submission url updates
660c040
danswick
danswick reviewed Mar 18, 2024
View reviewed changes
src/_includes/redirect.njk
<body>
You are being redirected to <a href="{{ config.baseUrl }}{{ redirect.to }}">{{ config.baseUrl }}{{ redirect.to }}</a>
</body>
</html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</html>
</html>

@danswick @phildominguez-gsa
Apply suggestions from code review
cffb3e5 
Co-authored-by: Phil Dominguez <142051477+phildominguez-gsa@users.noreply.github.com>
danswick
danswick reviewed Mar 18, 2024
View reviewed changes
src/api/rollups.md Outdated Show resolved Hide resolved
danswick
danswick reviewed Mar 18, 2024
View reviewed changes
src/api/rollups.md Outdated Show resolved Hide resolved
danswick
danswick reviewed Mar 18, 2024
View reviewed changes
src/api/rollups.md Outdated Show resolved Hide resolved
danswick
danswick reviewed Mar 18, 2024
View reviewed changes
src/api/rollups.md Outdated Show resolved Hide resolved
danswick
danswick reviewed Mar 18, 2024
View reviewed changes
src/api/rollups.md Outdated Show resolved Hide resolved
danswick
danswick reviewed Mar 18, 2024
View reviewed changes
src/api/rollups.md Outdated Show resolved Hide resolved
danswick
danswick reviewed Mar 18, 2024
View reviewed changes
src/api/rollups.md Outdated Show resolved Hide resolved
danswick
danswick reviewed Mar 18, 2024
View reviewed changes
src/api/rollups.md Outdated Show resolved Hide resolved
danswick
danswick reviewed Mar 18, 2024
View reviewed changes
src/api/rollups.md Outdated Show resolved Hide resolved
danswick
danswick approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@danswick danswick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to go ahead and approve this. There are some suggestions outstanding, but it turns out a number of them were on a file that wasn't actually added during this PR so I think we should come back to them later.

@danswick danswick dismissed phildominguez-gsa’s stale review March 18, 2024 23:05

see my approval message

@danswick danswick merged commit f78c551 into main Mar 19, 2024
3 checks passed
@danswick danswick deleted the jp/resource-pages branch March 19, 2024 01:12
@jperson1 jperson1 mentioned this pull request Mar 19, 2024
Closed
@danswick danswick mentioned this pull request Mar 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danswick danswick danswick approved these changes

@phildominguez-gsa phildominguez-gsa phildominguez-gsa left review comments

@James-Paul-Mason James-Paul-Mason Awaiting requested review from James-Paul-Mason

Assignees

@jperson1 jperson1

@lauraherring lauraherring

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lauraherring @James-Paul-Mason @jperson1 @danswick @phildominguez-gsa @jadudm