Fieldset edit operations added (#234)

* Put "add question" drop-down in the fieldset edit component. Initial attempt at removing items from the edit focus handler. TODO work making it possible to add multiple questions to a fieldset, updating the styling, and adding tests.

* Basic fieldset pattern adding working via downdown picker

* Split different drop-down stylings into separate components

* Use original file name, to make merge easier

* Fix finicky interaction tests that were only failing in jsdom

* Remove what looks like unused white background color; tweak drop-down width to accomodate fieldsets.

* Style "add question" button for fieldsets

* For speed reasons, don't create coverage report on the default "test" script.

* Add an interaction test for the fieldset's "add question" button

* Add "remove question" to fieldset edit ui

* Remove superfluous classnames rename

* Fix generic type in FormSummaryEdit ui

* Upgrade node to latest LTS (20.15.0) and update pnpm-lock.yaml

.github/workflows/_validate.yml

@@ -56,7 +56,7 @@ jobs:
 
       - name: Run test suite
         shell: bash
-        run: pnpm test
+        run: pnpm test:ci
 
       - name: Initialize Terraform CDK configuration
         shell: bash

.nvmrc

@@ -1 +1 @@
-v20.12.2
+v20.15.0

apps/spotlight/package.json

@@ -20,7 +20,6 @@
   },
   "devDependencies": {
     "@astrojs/check": "^0.4.1",
-    "@types/react": "^18.2.37",
-    "jsdom": "^23.0.1"
+    "@types/react": "^18.2.37"
   }
 }

package.json

@@ -12,7 +12,8 @@
     "format": "prettier --write \"packages/*/src/**/*.{js,jsx,ts,tsx,scss}\"",
     "lint": "turbo run lint",
     "pages": "rm -rf node_modules && npm i -g pnpm turbo && pnpm i && pnpm build && ln -sf ./apps/spotlight/dist _site",
-    "test": "vitest run --coverage.enabled --coverage.reporter=text --coverage.reporter=json-summary --coverage.reporter=json --coverage.reportOnFailure --reporter vitest-github-actions-reporter",
+    "test": "vitest run",
+    "test:ci": "vitest run --coverage.enabled --coverage.reporter=text --coverage.reporter=json-summary --coverage.reporter=json --coverage.reportOnFailure --reporter vitest-github-actions-reporter",
     "test:infra": "turbo run --filter=infra test",
     "typecheck": "tsc --build",
     "prepare": "husky"

packages/design/package.json

@@ -51,6 +51,7 @@
     "gulp": "^5.0.0",
     "http-server": "^14.1.1",
     "install": "^0.13.0",
+    "jsdom": "^24.1.0",
     "prop-types": "^15.8.1",
     "react-dom": "^18.2.0",
     "vite": "^5.2.11",