Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login.gov authentication #254

Merged
merged 74 commits into from
Aug 13, 2024
Merged

Login.gov authentication #254

merged 74 commits into from
Aug 13, 2024

Commits on Jul 6, 2024

  1. login.gov sign-in working, roughly.

    @danielnaab
    danielnaab committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    8f7dd4a View commit details
    Browse the repository at this point in the history

  2. Move login and logout to the header menu.

    @danielnaab
    danielnaab committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    78badcd View commit details
    Browse the repository at this point in the history

  3. For testing, trigger deploy on the login-gov branch

    @danielnaab
    danielnaab committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    23a08d9 View commit details
    Browse the repository at this point in the history

  4. Initial attempt at wiring login.gov credentials to deployed containers

    @danielnaab
    danielnaab committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    8c41316 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Add code to help manage secrets to the command-line interface.

    @danielnaab
    danielnaab committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d875654 View commit details
    Browse the repository at this point in the history

  2. Create service-like command functions for secrets, and unit tests. Wi… 

    …re up in the command-line controller.
    @danielnaab
    danielnaab committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    9d31e8d View commit details
    Browse the repository at this point in the history

  3. Improve cli app organization

    @danielnaab
    danielnaab committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    7ca86a3 View commit details
    Browse the repository at this point in the history

  4. Add set-login-gov-keys CLI command, use case, and tests.

    @danielnaab
    danielnaab committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e7e93cf View commit details
    Browse the repository at this point in the history

  5. Add ADR for secrets management.

    @danielnaab
    danielnaab committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    9c465ba View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/main' into login-gov

    @danielnaab
    danielnaab committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    f826440 View commit details
    Browse the repository at this point in the history

  7. Clarify README comment

    @danielnaab
    danielnaab committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e8b3d6d View commit details
    Browse the repository at this point in the history

  8. Fix bad comment

    @danielnaab
    danielnaab committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d66d7a7 View commit details
    Browse the repository at this point in the history

  9. Compare against correct value in test

    @danielnaab
    danielnaab committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    cb56266 View commit details
    Browse the repository at this point in the history

  10. Add missing files

    @danielnaab
    danielnaab committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    fb208d3 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Add key generation mocks in unit test.

    @danielnaab
    danielnaab committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    129459f View commit details
    Browse the repository at this point in the history

  2. remove vitest reporter that hasn't been working for quite some time

    @danielnaab
    danielnaab committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    8b8c304 View commit details
    Browse the repository at this point in the history

  3. Set AUTH_SECRET for the auth library we're using

    @danielnaab
    danielnaab committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    166b940 View commit details
    Browse the repository at this point in the history

  4. Explicitly read the AUTH_SECRET in auto.config.ts, rather than rely o… 

    …n the framework to read.
    @danielnaab
    danielnaab committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    1d34742 View commit details
    Browse the repository at this point in the history

  5. Move server secrets retrieval into secrets.ts

    @danielnaab
    danielnaab committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    fef924a View commit details
    Browse the repository at this point in the history

  6. experiment to revert - use hardcoded string for auth secret, in attem… 

    …pt to get tests passing in CI
    @danielnaab
    danielnaab committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ee1b410 View commit details
    Browse the repository at this point in the history

  7. To improve readability, use literal strings in login.gov unit test

    @danielnaab
    danielnaab committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    8280a08 View commit details
    Browse the repository at this point in the history

  8. Fix typing error in secrets package and organize its adapters into a … 

    …separate subdirectory.
    @danielnaab
    danielnaab committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    89e918f View commit details
    Browse the repository at this point in the history

  9. Add "delete secret" command (so I can clean up mispelled keys)

    @danielnaab
    danielnaab committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    1c9a410 View commit details
    Browse the repository at this point in the history

  10. Test deployment to dev

    @danielnaab
    danielnaab committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d6891aa View commit details
    Browse the repository at this point in the history

  11. sanity check on reading an environment variable

    @danielnaab
    danielnaab committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    feb0b0a View commit details
    Browse the repository at this point in the history

  12. Used consistent AUTH_SECRET in CI tests; randomness is unnecessary

    @danielnaab
    danielnaab committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    f067484 View commit details
    Browse the repository at this point in the history

  13. Remove debug exception

    @danielnaab
    danielnaab committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    aca9945 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Merge remote-tracking branch 'origin/main' into login-gov

    @danielnaab
    danielnaab committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    d0ab4ad View commit details
    Browse the repository at this point in the history

  2. Refashion secrets packages as infra/core

    @danielnaab
    danielnaab committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    c16376d View commit details
    Browse the repository at this point in the history

  3. Remove unused docassemble cli commands

    @danielnaab
    danielnaab committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    c76c642 View commit details
    Browse the repository at this point in the history

  4. Update infra references

    @danielnaab
    danielnaab committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    7d70496 View commit details
    Browse the repository at this point in the history

  5. fix infra dir in validate workflow

    @danielnaab
    danielnaab committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a46aca8 View commit details
    Browse the repository at this point in the history

  6. Fix infra-cdktf filtering in root package.json

    @danielnaab
    danielnaab committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    3005fe8 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Log in flow wired up w/o sessions. Also, TODO: track the nonce.

    @danielnaab
    danielnaab committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    202d672 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Add database package with an initial migration using Knex, with Kysel… 

    …y for query building.
    @danielnaab
    danielnaab committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    ae44485 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Add initial database package

    @danielnaab
    danielnaab committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c8d4641 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Organize database and auth code; trying to track down import problems… 

    … when the Astro build is integrated at the app level. I'll factor out the auth code first.
    @danielnaab
    danielnaab committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    7d6798d View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Create @atj/auth, and move logic in there.

    @danielnaab
    danielnaab committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    8217ca8 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Initial auth flow working, but tests of auth services still TODO. Int… 

    …egration tests in the demo servers are still failing.
    @danielnaab
    danielnaab committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    26045ba View commit details
    Browse the repository at this point in the history

  2. Add tests for getProviderCallback and logOut.

    @danielnaab
    danielnaab committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4048a1f View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Add nonce

    @danielnaab
    danielnaab committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    ab0de91 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2024

  1. Add createSession

    @danielnaab
    danielnaab committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    632fd86 View commit details
    Browse the repository at this point in the history

  2. Test for processProviderCallback. Includes fix to reuse sqlite3 conne… 

    …ction from knex.
    @danielnaab
    danielnaab committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    b55903f View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Add tests for process-session-cookie

    @danielnaab
    danielnaab committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    3f6ee77 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Manage database dependencies so the integrating form service apps may… 

    … import and run the server's express handler. This includes:

- Create helper in @atj/common to create service objects from a collection of service functions
- Remove module-global imports of @atj/database from the @atj/server, replacing with async imports where appropriate
TODO: The app integration tests for Kansas and DOJ are now passing, but the build bundle fails.
    @danielnaab
    danielnaab committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    947b2db View commit details
    Browse the repository at this point in the history

  2. Instantiate SSMClient in the AWSParameterStoreSecretsVault constructor

    @danielnaab
    danielnaab committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    446c62f View commit details
    Browse the repository at this point in the history

  3. Update dependencies, fix issue with dev server mode not working, rena… 

    …me DatabaseService to DatabaseGateway
    @danielnaab
    danielnaab committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    361deb6 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Work to get the app integrations running again, which primarily invol… 

    …ved using .js imports, so we are consistent with ESM loading rules.
    @danielnaab
    danielnaab committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    76c2757 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into login-gov

    @danielnaab
    danielnaab committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    6cda340 View commit details
    Browse the repository at this point in the history

  3. Trying to get the dependency graph command to work again. Will revisi… 

    …t later.
    @danielnaab
    danielnaab committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    946b292 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Use git commit hash rather than deployment identifier as the deployme… 

    …nt's docker tag
    @danielnaab
    danielnaab committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    940167a View commit details
    Browse the repository at this point in the history

  2. Upgrade more dependencies (trying to get coverage working, and failing)

    @danielnaab
    danielnaab committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    5b9f253 View commit details
    Browse the repository at this point in the history

  3. Remove tsup usage from libraries

    @danielnaab
    danielnaab committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    ffd5b9e View commit details
    Browse the repository at this point in the history

  4. Fix infra/cdktf filter in build script

    @danielnaab
    danielnaab committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    dd4906e View commit details
    Browse the repository at this point in the history

  5. Use correct base tsconfig in the design package.

    @danielnaab
    danielnaab committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    41eb076 View commit details
    Browse the repository at this point in the history

  6. Update design testing libraries

    @danielnaab
    danielnaab committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    83d5c5f View commit details
    Browse the repository at this point in the history

  7. Punt of getting code coverage working, for now. 

    Context: the design lib has an unhandled exception when coverage is enabled.
    @danielnaab
    danielnaab committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    39b708a View commit details
    Browse the repository at this point in the history

  8. Comment out davelosert/vitest-coverage-report-action@v2.5.0

    @danielnaab
    danielnaab committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3baf815 View commit details
    Browse the repository at this point in the history

  9. In the Terraform PR plan comment, use the target branch of the PR rat… 

    …her than a hard-coded "staging" value
    @danielnaab
    danielnaab committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    761381e View commit details
    Browse the repository at this point in the history

  10. Update e2e docker base image to newer playwright version

    @danielnaab
    danielnaab committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    ebaffe3 View commit details
    Browse the repository at this point in the history

  11. Upgrade Storybook to 8.2. 8.0 caused some problems on one dev machine… 

    …, so hoping the issues are resolved now.
    @danielnaab
    danielnaab committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    c669c04 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Fix missing .js extensions on db adapters

    @danielnaab
    danielnaab committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    7721539 View commit details
    Browse the repository at this point in the history

  2. Upgrade @storybook/test-runner to 0.19.1 (fixes build break)

    @danielnaab
    danielnaab committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    b692e9e View commit details
    Browse the repository at this point in the history

  3. Wire client secret from app to login.gov provider in deployed apps.

    @danielnaab
    danielnaab committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    43c274b View commit details
    Browse the repository at this point in the history

  4. Remove passage of private key to auth - it shouldn't be necessary wit… 

    …h PKCE. Revisit if we switch to the JWT method.
    @danielnaab
    danielnaab committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    6b9008b View commit details
    Browse the repository at this point in the history

  5. Make clientSecret undefined rather than an empty string

    @danielnaab
    danielnaab committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d6af3a7 View commit details
    Browse the repository at this point in the history

  6. Remove clientSecret from auth test

    @danielnaab
    danielnaab committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    3497832 View commit details
    Browse the repository at this point in the history

  7. Remove clientSecret from LoginGovOptions

    @danielnaab
    danielnaab committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    9c5168b View commit details
    Browse the repository at this point in the history

  8. Add extra debug logging for failed authorization code checks

    @danielnaab
    danielnaab committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    bc44d2d View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Remove deploy trigger from login-gov feature branch

    @danielnaab
    danielnaab committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    7edc396 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary login.gov bash script (superceded by CLI commands)

    @danielnaab
    danielnaab committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    b5ad83e View commit details
    Browse the repository at this point in the history

  3. Remove old comment

    @danielnaab
    danielnaab committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    a2a4890 View commit details
    Browse the repository at this point in the history

  4. Add comment explaining createService

    @danielnaab
    danielnaab committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    9e1d1dc View commit details
    Browse the repository at this point in the history

  5. Remove lucia from web server package, in lieu of the auth package.

    @danielnaab
    danielnaab committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    c197ecd View commit details
    Browse the repository at this point in the history