Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontmatter to pull revision details #40

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

rahearn
Copy link
Contributor

@rahearn rahearn commented Sep 23, 2024

🎫 Addresses issue: https://github.com/GSA-TTS/devtools-compliance/issues/25

🛠 Summary of changes

  • pull document revision history table details from metadata.revisions
  • Uses an optional non-standard prop to the revisions object with name prepared-by and value of a party uuid to populate the "author" of each revision. Otherwise it falls back to the first 'prepared-by' responsible party.
  • updates the OSCAL_REFERENCE table with more metadata details

@rahearn rahearn requested a review from a team September 23, 2024 17:34
@rahearn rahearn self-assigned this Sep 23, 2024
zjrgov
zjrgov previously approved these changes Sep 24, 2024
OSCAL_REFERENCE.md Outdated Show resolved Hide resolved
Co-authored-by: Zachary Rollyson <zachary.rollyson@gsa.gov>
@rahearn rahearn requested a review from zjrgov September 24, 2024 14:32
Copy link
Contributor

@zjrgov zjrgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get why it works that way for suggestions.

@rahearn rahearn merged commit eb264a7 into main Sep 24, 2024
1 check passed
@rahearn rahearn deleted the document-revision-support branch September 24, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants