Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview link comment to PRs #660

Merged
merged 12 commits into from
Nov 19, 2024
Merged

Add preview link comment to PRs #660

merged 12 commits into from
Nov 19, 2024

Conversation

wesley-dean-gsa
Copy link
Contributor

@wesley-dean-gsa wesley-dean-gsa commented Nov 19, 2024

Changes proposed in this pull request

This adds a comment with a link that's more visible to the PR to make it easier to preview a branch

security considerations

None.

ximekilgsa and others added 3 commits November 14, 2024 12:02
Copy link

github-actions bot commented Nov 19, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 21.43% 42/196
🔴 Branches 37.14% 39/105
🔴 Functions 38.46% 5/13
🔴 Lines 21.43% 42/196

Test suite run success

7 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 7e0e0f0

Copy link

github-actions bot commented Nov 19, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 7 0 0.1s
✅ BASH shellcheck 6 0 0.29s
✅ BASH shfmt 6 0 0 0.25s
⚠️ CSS scss-lint 2 1 3.26s
✅ JAVASCRIPT prettier 13 0 0 1.48s
✅ JSON jsonlint 8 0 0.2s
✅ JSON npm-package-json-lint yes no 0.49s
✅ JSON prettier 8 0 0 1.39s
✅ JSON v8r 8 0 11.98s
⚠️ MARKDOWN markdownlint 37 0 46 2.07s
⚠️ MARKDOWN markdown-link-check 37 2 12.27s
✅ MARKDOWN markdown-table-formatter 37 0 0 0.39s
✅ REPOSITORY checkov yes no 16.72s
✅ REPOSITORY gitleaks yes no 0.37s
✅ REPOSITORY git_diff yes no 0.26s
⚠️ REPOSITORY grype yes 2 14.62s
✅ REPOSITORY secretlint yes no 2.87s
✅ REPOSITORY trivy yes no 8.92s
✅ REPOSITORY trivy-sbom yes no 1.41s
✅ REPOSITORY trufflehog yes no 3.78s
⚠️ SPELL cspell 37 1 3.95s
✅ YAML prettier 19 0 0 1.3s
✅ YAML v8r 14 0 16.5s
✅ YAML yamllint 19 0 0.64s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

Preview This Branch

You may view the preview version of the site with the following URL:

https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/preview_button/

It may take a minute before changes in this Pull Request (PR) show up ⏱️

@wesley-dean-gsa wesley-dean-gsa changed the title Merge pull request #652 from GSA-TTS/staging Add preview link comment to PRs Nov 19, 2024
@wesley-dean-gsa wesley-dean-gsa marked this pull request as ready for review November 19, 2024 13:29
@wesley-dean-gsa wesley-dean-gsa requested a review from a team as a code owner November 19, 2024 13:29
@wesley-dean-gsa
Copy link
Contributor Author

The workflow has attempts to fetch the default page and retries up to 18 times with a 10 second delay between retries; if the URL won't build after 3 minutes, there are other things going on.

I had a thing where it would remove the comment at the start of the workflow, delay for some time while the site was (re-)built, and then return the comment with the logic being that the comment should disappear while the site is being built. That worked... but it also resulted in notifications every time the workflow ran and that wasn't much fun.

@wesley-dean-gsa wesley-dean-gsa merged commit 4fb062a into staging Nov 19, 2024
17 checks passed
@wesley-dean-gsa wesley-dean-gsa deleted the preview_button branch November 19, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants