Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Touchpoints #694

Closed
wants to merge 4 commits into from
Closed

Conversation

ryanwoldatwork
Copy link

Screenshot 2024-12-13 at 2 23 22 PM

@ryanwoldatwork ryanwoldatwork requested a review from a team as a code owner December 13, 2024 22:23
Copy link
Contributor

@wesley-dean-gsa wesley-dean-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.

I see that some tests are failing; upon further review, I see that they're a result of running the actions in a fork which doesn't have a PAT setup (why would it?). The HTML as-written is fine; if MegaLinter or Prettier want to reformat it, that's fine, too.

Copy link
Contributor

@wesley-dean-gsa wesley-dean-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.

I see that some tests are failing; upon further review, I see that they're a result of running the actions in a fork which doesn't have a PAT setup (why would it?). The HTML as-written is fine; if MegaLinter or Prettier want to reformat it, that's fine, too.

@debjudy
Copy link
Contributor

debjudy commented Dec 18, 2024

Because of issues mentioned note above by Wes, we submitted separate PR to implement this update. #703
Update is on Staging: https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/staging/ and will be pushed to production with our next update.

@debjudy debjudy closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants