[40] Create Rails SecurityLog model #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepchud
reviewed
Aug 7, 2024
spec/models/security_log_spec.rb
Outdated
Comment on lines
23
to
27
| it 'validates presence of action' do | ||
| security_log = described_class.new(action: nil) | ||
| expect(security_log).not_to be_valid | ||
| expect(security_log.errors[:action]).to include("can't be blank") | ||
| end |
There was a problem hiding this comment.
can this use the new shared_example?
Suggested change
| it 'validates presence of action' do | |
| security_log = described_class.new(action: nil) | |
| expect(security_log).not_to be_valid | |
| expect(security_log.errors[:action]).to include("can't be blank") | |
| end | |
| it_behaves_like 'a model with required attributes', [:actoin] |
There was a problem hiding this comment.
I was getting errors saying when i did a binding pry i believe the issue was with the set_logged_at so i will try it again with the other suggestion you commented
stepchud
reviewed
Aug 7, 2024
stepchud
reviewed
Aug 7, 2024
Comment on lines
+46
to
+48
| def set_logged_at | ||
| self.logged_at ||= DateTime.now | ||
| end |
There was a problem hiding this comment.
I just reviewed a similar issue on a different PR and found this SO solution. I think we can leverage the timestamp_attributes_for_create method like this:
private_class_method
def self.timestamp_attributes_for_create
super << 'logged_at'
end
stepchud
reviewed
Aug 8, 2024
Co-authored-by: Stephen Chudleigh <stepchud@users.noreply.github.com>
stepchud
reviewed
Aug 9, 2024
|
|
||
| RSpec.describe SecurityLog do | ||
| describe 'Security Log validations' do | ||
| it_behaves_like 'a model with required attributes', [:action] |
There was a problem hiding this comment.
@bilalhankins I added this line, works fine for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created rails SecurityLog Model
Added basic spec tests