-
Notifications
You must be signed in to change notification settings - Fork 9
Decouple flask app #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Decouple flask app #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
3 tasks
3ffe7e7
to
b7afe29
Compare
b7afe29
to
be41f04
Compare
833eff2
to
3f24f03
Compare
3f24f03
to
e82f717
Compare
e82f717
to
cd9f35d
Compare
33877bd
to
0ab2eea
Compare
0ab2eea
to
42e38e1
Compare
cb07fef
to
ee40dcd
Compare
makes paginate decorator cleaner; adds harvest clear helper to clean up records in error; TODO: figure out why clear helper has dirty records in a test system
delete harvest record now deletes all instances of a record; explicitly close the db connection after a harvest; clean up README; adds steps to document harvesting to local CKAN
removes follow-up and restart jobs in favor of sync; adds validate job tests; adds records_validated to harvest_job model; other responses to feedback
This reverts commit 1c2b627.
43d5fb5
to
62a949d
Compare
rshewitt
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we got a lotta good work over here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related to GSA/data.gov#4865
About
Allows us to run follow-up jobs to sync records which may have previously errored out due network side-effects.
Moves towards ability to run harvest clear and records validation as first-class jobs.
EDIT: This PR is a beast. Make sure to expand the changes to
harvester/harvest.py
. I recommend looking at those in the side-by-side editor as it's a thorough rewrite.PR TASKS