Skip to content

Decouple flask app #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jan 30, 2025
Merged

Decouple flask app #115

merged 29 commits into from
Jan 30, 2025

Conversation

btylerburton
Copy link
Contributor

@btylerburton btylerburton commented Nov 21, 2024

Pull Request

Related to GSA/data.gov#4865

About

Allows us to run follow-up jobs to sync records which may have previously errored out due network side-effects.

Moves towards ability to run harvest clear and records validation as first-class jobs.

EDIT: This PR is a beast. Make sure to expand the changes to harvester/harvest.py. I recommend looking at those in the side-by-side editor as it's a thorough rewrite.

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Any changes to docs?

@btylerburton
Copy link
Contributor Author

btylerburton commented Nov 21, 2024

DRAFT WIP: not finished yet... but wanted to put this up as we're pausing on harvester work for a sprint and having eyes on this could help clean it up...

@btylerburton btylerburton marked this pull request as ready for review January 22, 2025 16:28
@btylerburton btylerburton requested a review from a team January 22, 2025 16:29
Copy link
Contributor

@rshewitt rshewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we got a lotta good work over here!

@rshewitt rshewitt merged commit 7203cdc into main Jan 30, 2025
4 checks passed
@rshewitt rshewitt deleted the decouple-flask-app branch January 30, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants