Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ckanification utilities #34

Merged
merged 5 commits into from
Feb 6, 2024
Merged

ckanification utilities #34

merged 5 commits into from
Feb 6, 2024

Conversation

rshewitt
Copy link
Contributor

@rshewitt rshewitt commented Feb 6, 2024

Pull Request

Related to #4599

About

add ckan string scrubbing utilities

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Any changes to docs?
  • Bumped version number in pyproject.toml (also checked on PyPi).

@rshewitt rshewitt requested a review from a team February 6, 2024 21:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
harvester
   __init__.py00100% 
   ckan_utils.py4222 95%
   harvest.py4116767 84%
   utils.py4377 84%
TOTAL4967685% 

Tests Skipped Failures Errors Time
22 0 💤 0 ❌ 0 🔥 4.049s ⏱️

@rshewitt rshewitt changed the title ckanification utiltiies ckanification utilities Feb 6, 2024
btylerburton
btylerburton approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@btylerburton btylerburton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

harvester/ckan_utils.py Show resolved Hide resolved
@rshewitt rshewitt merged commit 369b124 into main Feb 6, 2024
1 check passed
@rshewitt rshewitt deleted the load-test-fixes branch February 6, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btylerburton btylerburton btylerburton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rshewitt @btylerburton