Add Constraints For Issue #942 (#1001)

* Add constraints and tests for issue #942 * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: A.J. Stein <aj@gsa.gov> * Update src/validations/constraints/fedramp-external-allowed-values.xml Co-authored-by: A.J. Stein <aj@gsa.gov> * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: A.J. Stein <aj@gsa.gov> --------- Co-authored-by: A.J. Stein <aj@gsa.gov>
GSA · Dec 17, 2024 · 0e21fa2 · 0e21fa2
1 parent b8ffdc5
commit 0e21fa2
Show file tree

Hide file tree

Showing 10 changed files with 84 additions and 11 deletions.
diff --git a/features/fedramp_extensions.feature b/features/fedramp_extensions.feature
@@ -100,8 +100,10 @@ Examples:
   | import-profile-has-available-document |
   | import-profile-resolves-to-fedramp-content |
   | incomplete-implemented-requirements |
+  | information-type |
   | information-type-800-60-v2r1 |
   | information-type-has-availability-impact |
+  | information-type-has-class |
   | information-type-has-confidentiality-impact |
   | information-type-has-integrity-impact |
   | information-type-system |
@@ -318,8 +320,12 @@ Examples:
   | import-profile-resolves-to-fedramp-content-PASS.yaml |
   | incomplete-implemented-requirements-FAIL.yaml |
   | incomplete-implemented-requirements-PASS.yaml |
+  | information-type-FAIL.yaml |
+  | information-type-PASS.yaml |
   | information-type-has-availability-impact-FAIL.yaml |
   | information-type-has-availability-impact-PASS.yaml |
+  | information-type-has-class-FAIL.yaml |
+  | information-type-has-class-PASS.yaml |
   | information-type-has-confidentiality-impact-FAIL.yaml |
   | information-type-has-confidentiality-impact-PASS.yaml |
   | information-type-has-integrity-impact-FAIL.yaml |

diff --git a/src/content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml b/src/content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
@@ -922,8 +922,8 @@
                <p>If 'not-applicable', attest explain why authentication is not applicable in the remarks.</p>
             </remarks>
          </prop>
-         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" value="C.3.5.1"/>
-         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" value="C.3.5.8"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" class="incoming" value="C.3.5.1"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" class="outgoing" value="C.3.5.8"/>
          <status state="operational"/>
 
          <responsible-role role-id="provider">
@@ -1028,8 +1028,8 @@
          </description>
          <prop name="leveraged-authorization-uuid" value="11111111-2222-4000-8000-019000000001"/>
          <prop name="implementation-point" value="external"/>
-         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" value="C.3.5.1"/>
-         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" value="C.3.5.8"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" class="incoming" value="C.3.5.1"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" class="outgoing" value="C.3.5.8"/>
          <link rel="provided-by" href="#11111111-2222-4000-8000-009000100001"/>
          <status state="operational"/>
          <responsible-role role-id="administrator">
@@ -1099,8 +1099,8 @@
                <p>If 'not-applicable', attest explain why authentication is not applicable in the remarks.</p>
             </remarks>
          </prop>
-         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" value="C.3.5.1" />
-         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" value="C.3.5.8" />
+         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" class="incoming" value="C.3.5.1" />
+         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" class="outgoing" value="C.3.5.8" />
          <prop name="poam-item-uuid" ns="https://fedramp.gov/ns/oscal" value="11111111-3333-4000-8000-000000000001" />
          <prop name="poam-id" ns="https://fedramp.gov/ns/oscal" value="ID-0001" />
          <link rel="provided-by" href="#11111111-2222-4000-8000-009000100001" />
@@ -1277,8 +1277,8 @@
                <p>If 'not-applicable', attest explain why authentication is not applicable in the remarks.</p>
             </remarks>
          </prop>
-         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" value="C.3.5.1"/>
-         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" value="C.3.5.8"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" class="incoming" value="C.3.5.1"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" class="outgoing" value="C.3.5.8"/>
          <prop ns="https://fedramp.gov/ns/oscal" name="compliance" value="soc-2-type-1"/>
          <prop ns="https://fedramp.gov/ns/oscal" name="compliance" value="pci-dss"/>
          <prop ns="https://fedramp.gov/ns/oscal" name="compliance" value="iso-27001"/>
@@ -1422,8 +1422,8 @@
                <p>If 'not-applicable', attest explain why authentication is not applicable in the remarks.</p>
             </remarks>
          </prop>
-         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" value="C.3.5.1"/>
-         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" value="C.3.5.8"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" class="incoming" value="C.3.5.1"/>
+         <prop ns="https://fedramp.gov/ns/oscal" name="information-type" class="outgoing" value="C.3.5.8"/>
          <prop name="inherited-uuid" value="22222222-0000-4000-9001-009000000001">
             <remarks>
                <p>This can only be known if provided by the leveraged system.

diff --git a/src/validations/constraints/content/ssp-information-type-INVALID.xml b/src/validations/constraints/content/ssp-information-type-INVALID.xml
@@ -0,0 +1,9 @@
+<system-security-plan xmlns="http://csrc.nist.gov/ns/oscal/1.0" uuid="11111111-2222-4000-8000-000000000000">
+  <system-implementation>
+    <component uuid="11111111-2222-4000-8000-009000100001" type="system">
+      <!-- The information type props don't have one of the correct allowed-values (incoming/outgoing) -->
+      <prop ns="https://fedramp.gov/ns/oscal" name="information-type" class="neither" value="C.3.5.1"/>
+      <prop ns="https://fedramp.gov/ns/oscal" name="information-type" class="neither" value="C.3.5.8"/>
+    </component>
+  </system-implementation>
+</system-security-plan>
diff --git a/src/validations/constraints/content/ssp-information-type-has-class-INVALID.xml b/src/validations/constraints/content/ssp-information-type-has-class-INVALID.xml
@@ -0,0 +1,13 @@
+<system-security-plan xmlns="http://csrc.nist.gov/ns/oscal/1.0" uuid="11111111-2222-4000-8000-000000000000">
+  <system-implementation>
+    <component uuid="11111111-2222-4000-8000-009000100001" type="system">
+      <!-- 
+      <prop ns="https://fedramp.gov/ns/oscal" name="information-type" class="incoming" value="C.3.5.1"/>
+      <prop ns="https://fedramp.gov/ns/oscal" name="information-type" class="outgoing" value="C.3.5.8"/> 
+      -->
+      <!-- The information-type props are missing the @class attribute. -->
+      <prop ns="https://fedramp.gov/ns/oscal" name="information-type" value="C.3.5.1"/>
+      <prop ns="https://fedramp.gov/ns/oscal" name="information-type" value="C.3.5.8"/>
+    </component>
+  </system-implementation>
+</system-security-plan>
diff --git a/src/validations/constraints/fedramp-external-allowed-values.xml b/src/validations/constraints/fedramp-external-allowed-values.xml
@@ -146,6 +146,14 @@
                 <enum value="fedramp-3.0.0rc1-oscal-1.1.2">FedRAMP Version</enum>
             </allowed-values>
 
+            <allowed-values id="information-type" target="//component/prop[@name='information-type' and @ns='https://fedramp.gov/ns/oscal']/@class" allow-other="no" level="ERROR">
+                <formal-name>Information Type</formal-name>
+                <description>The class of an information type property categorizes the direction of the data flow relative to the system described in the SSP.</description>
+                <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/4-ssp-template-to-oscal-mapping/#leveraged-fedramp-authorized-services"/>
+                <enum value="incoming">An incoming data flow to the system for this information type</enum>
+                <enum value="outgoing">An outgoing data flow from the system for this information type</enum>
+            </allowed-values>
+
             <allowed-values id="information-type-800-60-v2r1" target="(system-characteristics/system-information/information-type/categorization[@system='https://doi.org/10.6028/NIST.SP.800-60v2r1']/information-type-id | //component[(@type='system' and prop[@name='leveraged-authorization-uuid']) or (@type=('service', 'software') and not(prop[@name='leveraged-authorization-uuid']) and  prop[@name='implementation-point' and @value='external']) or (@type='interconnection') or (@type=('service', 'software') and prop[@name='implementation-point' and @value='internal'] and prop[@name='communicates-externally' and @value='yes' and @ns='https://fedramp.gov/ns/oscal'])]/prop[@ns='https://fedramp.gov/ns/oscal' and @name='information-type']/@value)" allow-other="no" level="ERROR">
                 <formal-name>NIST SP 800-60 Volume 2 Revision 1 Information Types</formal-name>
                 <description>Contains a list of all supported information types from NIST SP 800-60 Volume 2 Revision 1.</description>

diff --git a/src/validations/constraints/fedramp-external-constraints.xml b/src/validations/constraints/fedramp-external-constraints.xml
@@ -547,8 +547,13 @@
                 <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/5-attachments/#system-inventory-approach"/>
                 <message>A FedRAMP SSP system implementation section MUST have at least two inventory items.</message>
             </expect>
+            <expect id="information-type-has-class" target="component/prop[@name='information-type' and @ns='https://fedramp.gov/ns/oscal']" test="exists(@class)" level="ERROR">
+                <formal-name>Information Type Has Class</formal-name>
+                <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/4-ssp-template-to-oscal-mapping/#leveraged-fedramp-authorized-services"/>
+                <message>In a FedRAMP SSP, each information type property in a component MUST categorize the class of data flow as incoming to the system, outgoing from the system, or both.</message>
+            </expect>
             <expect id="inter-boundary-component-direction-incoming-has-ipv-uri" target="$inter-boundary-component" test="if (prop[@name='direction' and @value='incoming']) then exists(prop[@class='local' and @name=('ipv4-address','ipv6-address')]) or exists(link[@rel='uri']) else true()" level="ERROR">
-               <formal-name>Inter-Boundary Incoming Communication Direction Has an IPV Address or a URI</formal-name>
+               <formal-name>Inter-Boundary Incoming Communication Direction Has an IP Address or a URI</formal-name>
                <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/4-ssp-template-to-oscal-mapping/#external-systems-and-services-not-having-fedramp-authorization"/>
                <message>Component {@uuid} ({path(.)}) MUST have at least one local ipv4 address, ipv6 address, or a URI to an API.</message>
             </expect>

diff --git a/src/validations/constraints/unit-tests/information-type-FAIL.yaml b/src/validations/constraints/unit-tests/information-type-FAIL.yaml
@@ -0,0 +1,7 @@
+test-case:
+  name: Negative Test for information-type
+  description: This test case validates the behavior of constraint information-type
+  content: ../content/ssp-information-type-INVALID.xml
+  expectations:
+    - constraint-id: information-type
+      result: fail
diff --git a/src/validations/constraints/unit-tests/information-type-PASS.yaml b/src/validations/constraints/unit-tests/information-type-PASS.yaml
@@ -0,0 +1,7 @@
+test-case:
+  name: Positive Test for information-type
+  description: This test case validates the behavior of constraint information-type
+  content: ../../../content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
+  expectations:
+    - constraint-id: information-type
+      result: pass
diff --git a/src/validations/constraints/unit-tests/information-type-has-class-FAIL.yaml b/src/validations/constraints/unit-tests/information-type-has-class-FAIL.yaml
@@ -0,0 +1,9 @@
+test-case:
+  name: Negative Test for information-type-has-class
+  description: >-
+    This test case validates the behavior of constraint
+    information-type-has-class
+  content: ../content/ssp-information-type-has-class-INVALID.xml
+  expectations:
+    - constraint-id: information-type-has-class
+      result: fail
diff --git a/src/validations/constraints/unit-tests/information-type-has-class-PASS.yaml b/src/validations/constraints/unit-tests/information-type-has-class-PASS.yaml
@@ -0,0 +1,9 @@
+test-case:
+  name: Positive Test for information-type-has-class
+  description: >-
+    This test case validates the behavior of constraint
+    information-type-has-class
+  content: ../../../content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
+  expectations:
+    - constraint-id: information-type-has-class
+      result: pass