Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iventory-item-or-component-has-virtual Constraint #1055

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Gabeblis
Copy link
Contributor

Committer Notes

Purpose

This PR aims to add the iventory-item-or-component-has-virtual constraint which ensures that every inventory item, or it's linked component, is virtual or not by checking for the existence and value of the "virtual" prop.

Changes

Added constraint:

  • iventory-item-or-component-has-virtual

Added valid/invalid test content:

  • ssp-iventory-item-or-component-has-virtual-INVALID.xml
  • Edited fedramp-ssp-example.oscal.xml to align with constraint

Added yaml files for testing:

  • Pass/fail yaml tests added for each of the above constraints.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Dec 31, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner December 31, 2024 14:47
@Gabeblis Gabeblis linked an issue Dec 31, 2024 that may be closed by this pull request
14 tasks
@Gabeblis Gabeblis force-pushed the constraints/issue-1027 branch from 4850875 to be0c369 Compare January 6, 2025 12:04
@Gabeblis Gabeblis requested review from Rene2mt and a team January 10, 2025 16:07
@Gabeblis Gabeblis force-pushed the constraints/issue-1027 branch from be0c369 to 5b4d155 Compare January 13, 2025 14:14
@Gabeblis Gabeblis merged commit 2b00ff6 into GSA:develop Jan 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory - Virtual Asset
3 participants