This repository was archived by the owner on Jul 1, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 116
Add ADR for attachment handling for #1061 #1062
Merged
aj-stein-gsa
merged 8 commits into
GSA:develop
from
aj-stein-gsa:1061-design-approach-for-managing-oscal-and-non-oscal-attachments
Jan 23, 2025
Merged
Add ADR for attachment handling for #1061 #1062
aj-stein-gsa
merged 8 commits into
GSA:develop
from
aj-stein-gsa:1061-design-approach-for-managing-oscal-and-non-oscal-attachments
Jan 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not necessarily ready for review right right now, but it will be later in the afternoon and more importantly for others first thing Monday once I am on leave. So on that note, I will be changing status for my future aspirations now. 😄 |
2 tasks
eff7c18
to
2034743
Compare
wandmagic
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rmf-use is a good choice for the param, i like this solution
Rene2mt
reviewed
Jan 14, 2025
Rene2mt
approved these changes
Jan 17, 2025
OK I am going to merge this and coordinate on new constraints to merge and revising others (at least writing up and scoping issues, whether or not they are not completed for an upcoming release). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Closes #1061.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.