Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue-1043 Constraints #1087

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

Gabeblis
Copy link
Contributor

@Gabeblis Gabeblis commented Jan 9, 2025

Committer Notes

Purpose

This PR aims to add the inventory-item-has-diagram-label and component-has-diagram-label constraints which help ensure that there is a "diagram-label" prop in each inventory item or "hardware", "software", "service", or "interconnection" component that isn't linked to an inventory item.

Changes

Added constraints:

  • inventory-item-has-diagram-label
  • component-has-diagram-label

Added valid/invalid test content:

  • ssp-inventory-item-has-diagram-label-INVALID.xml
  • ssp-component-has-diagram-label-INVALID.xml
  • Edited fedramp-ssp-example.oscal.xml to align with constraints.

Added yaml files for testing:

  • Pass/fail yaml tests added for each of the above constraints.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Jan 9, 2025
@Gabeblis Gabeblis requested a review from a team as a code owner January 9, 2025 15:38
@Gabeblis Gabeblis linked an issue Jan 9, 2025 that may be closed by this pull request
16 tasks
@Gabeblis Gabeblis force-pushed the constraints/issue-1043 branch from 0ea2bfc to 4404ef5 Compare January 9, 2025 15:58
wandmagic
wandmagic previously approved these changes Jan 9, 2025
Rene2mt
Rene2mt previously approved these changes Jan 10, 2025
Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!! Just needs a final rebase before merging.

@Gabeblis Gabeblis dismissed stale reviews from Rene2mt and wandmagic via 1381cbe January 10, 2025 21:58
@Gabeblis Gabeblis force-pushed the constraints/issue-1043 branch from 4404ef5 to 1381cbe Compare January 10, 2025 21:58
@Gabeblis Gabeblis requested review from Rene2mt and wandmagic January 13, 2025 14:07
@wandmagic wandmagic merged commit 35fe9a3 into GSA:develop Jan 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory - Diagram Label
3 participants