Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inventory-item-not-system-or-validation Constraint #1139

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

Gabeblis
Copy link
Contributor

Committer Notes

Purpose

This PR aims to add the inventory-item-not-system-or-validation constraint which ensures that an inventory item MUST NOT reference a "system" component nor a "validation" component.

Changes

Added constraint:

  • inventory-item-not-system-or-validation

Added valid/invalid test content:

  • ssp-inventory-item-not-system-or-validation-INVALID.xml

Added yaml files for testing:

  • Pass/fail yaml tests added for each of the above constraints.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis requested a review from a team as a code owner January 31, 2025 16:12
@Gabeblis Gabeblis force-pushed the constraints/issue-1096 branch from 6791fae to 83e8000 Compare January 31, 2025 16:19
Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@aj-stein-gsa aj-stein-gsa merged commit 830ecb2 into GSA:develop Jan 31, 2025
6 checks passed
@Gabeblis Gabeblis linked an issue Feb 4, 2025 that may be closed by this pull request
17 tasks
@Gabeblis Gabeblis deleted the constraints/issue-1096 branch February 4, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory item Additional Constraints
3 participants