Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Greek Translation #1776

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Updated Greek Translation #1776

merged 1 commit into from
Apr 9, 2024

Conversation

Pyrofanis
Copy link
Contributor

Hi i updated the greek translation
it needed less work that i thought for the time passed but anyway
if any problem occurs contact me

Best Regards
Nasos

@ferdnyc ferdnyc mentioned this pull request Apr 5, 2024
Copy link
Member

@ferdnyc ferdnyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question about the escaped quotes is sort of tangential, this looks good to me regardless. Thanks, @Pyrofanis!

Comment on lines +1068 to +1072
#. TRANSLATORS: eg. Failed to send "book.pdf" to Google Pixel
#: src/service/plugins/share.js:321
#, javascript-format
msgid "Failed to send “%s” to %s"
msgstr "Απέτυχε η αποστολή του \"%s\" στο %s"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyholmes Went to great lengths, a bunch of years ago, to "smart-quotes-ify" the translations (e3c8765).

While I realize that...

  1. we didn't have Greek translations, at the time, and
  2. escaped quotes appeared in the previous version of el.po as well, so it's not like it's something you introduced

...I'm just wondering if there's some form of valid quoting in Greek that uses non-ASCII quotation marks? (Whether it's “foo”, „foo”, 「foo」, «foo», or something else?)

If not, then escaping we will go!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well the main differences i can pin point from my mind right now is that more commonly

for quotation marks we <<Κατι ειναι εδω >> but i have found and articles that contain ¨ ¨
there might not be ascii since these are in the Greek keyboard layout and are located where : is

also in case you might find it in Greek we use ; as a question mark and ? doesn't exist

in texts where there is a dialog or you want to give more information about something we use : but i think that this is common in English also
if you have any other questions feel free to ask :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-ASCII is totally fine for translations, so I think whatever Greek users expect is the best choice. I'd defer to your judgement as a translator for what's best 👍

@andyholmes
Copy link
Collaborator

Alrighty, merging as-is for for now so it gets in for v57, but feel free to submit any amendments you see fit :)

@andyholmes andyholmes merged commit 24a4b87 into GSConnect:main Apr 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants