Cleanup/fix notification code for GNOME 46 #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellandau
approved these changes
Apr 2, 2024
Closed
ferdnyc
reviewed
Apr 4, 2024
|
|
||
| /* | ||
| * Reimplementation of MessageTray.addNotification to raise the usual | ||
| * notification limit (3) |
There was a problem hiding this comment.
(Belatedly, sorry... but...)
I wonder if this is a good idea? Just because, GNOME could change the notification limit from 3 tomorrow, and then the comment's wrong. The more important point is probably that we raise it to 10.
I mean, it's just a comment, so it's not worth a PR just to change it anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1775
Fixes #1771 (comment)