Fix MPRIS seeking and SetPosition #1783
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the math we use to perform seek operations via MPRIS, since KDEConnect uses microseconds for seek offsets even though they use milliseconds for position values. (MPRIS uses microseconds everywhere.)
Also, implement
SetPosition()
directly instead of computing the offset from the current position and callingSeek()
, because some players don't respect arbitrarySeek()
lengths.Picking up the currently-playing
trackid
at the time theSetPosition()
call is handled and assuming it's the same track it was intended for is somewhat risky, but picking up the currentPosition
and making the same assumption (which is what the previous code did) carried the exact same amount of risk.Fixes: #1779