Feature: Add multiple file transfer, directory transfer from Nautilus

[ferdnyc]

This PR adds the ability to transfer multiple files at once over the KDEConnect "share files" link, and upgrades the Nautilus/Nemo extension with the ability to both handle multi-select (sending all of the selected items), and to send directory trees via temporarily-created .zip files, which are deleted by the JS code after transferring the files (successfully or not).

Fixes: #1025

[ferdnyc]

I also added a commit setting the flake8 maximum line length to 80, because there was a conflict where black would reformat a statement of exactly 80 characters to one line, then flake8 would complain about it and want it wrapped, but then black would want to reformat it back to one line... Pulled out to a separate PR.

[ferdnyc]

I'll have to figure out what about these changes are breaking testSharePlugin.js, plus it would be good to add some new tests for the new functionality.

[ferdnyc]

@andyholmes I was hoping you might be able to give me some insight into why the CI is failing.

The failure is in testSharePlugin.js, which makes sense as that's the plugin I modified. The specific failure is test 2, "The share plugin enables its GActions when connected". Here's that portion of gsconnect_plugins_testSharePlugin.test.txt:

not ok 2 The share plugin enables its GActions when connected
# Message: Expected false to be true.
# Stack:
#   error properties: Object({ matches: Function })
#   @file:///usr/libexec/installed-tests/gsconnect/plugins/testSharePlugin.js:58:67
#   setTimeout/source<@resource:///org/gnome/gjs/modules/esm/_timers.js:72:9
#   _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34
# Message: Expected false to be true.
# Stack:
#   error properties: Object({ matches: Function })
#   @file:///usr/libexec/installed-tests/gsconnect/plugins/testSharePlugin.js:58:67
#   setTimeout/source<@resource:///org/gnome/gjs/modules/esm/_timers.js:72:9
#   _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34
# Message: Expected false to be true.
# Stack:
#   error properties: Object({ matches: Function })
#   @file:///usr/libexec/installed-tests/gsconnect/plugins/testSharePlugin.js:61:68
#   setTimeout/source<@resource:///org/gnome/gjs/modules/esm/_timers.js:72:9
#   _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34
# Message: Expected false to be true.
# Stack:
#   error properties: Object({ matches: Function })
#   @file:///usr/libexec/installed-tests/gsconnect/plugins/testSharePlugin.js:61:68
#   setTimeout/source<@resource:///org/gnome/gjs/modules/esm/_timers.js:72:9
#   _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

I did add a couple of new actions to the plugin. The only reason I can think of that they might not be activating is, both of the new actions have kdeconnect.share.request.update as one of their outgoing message types; that message is also added to the outgoingCapabilities of the plugin itself.

testSharePlugin.js currently configures its test rig with only the kdeconnect.share.request message as both incoming and outgoing:

gnome-shell-extension-gsconnect/installed-tests/suites/plugins/testSharePlugin.js

Lines 12 to 32 in 97a1287

	beforeAll(async function () {
	testRig = new Utils.TestRig();
	await testRig.prepare({
	localDevice: {
	incomingCapabilities: [
	'kdeconnect.share.request',
	],
	outgoingCapabilities: [
	'kdeconnect.share.request',
	],
	},
	remoteDevice: {
	incomingCapabilities: [
	'kdeconnect.share.request',
	],
	outgoingCapabilities: [
	'kdeconnect.share.request',
	],
	},
	});
	testRig.setPaired(true);

Do I need to add kdeconnect.share.request.update to the test rig, to get the new actions to auto-enable? At which endpoint(s)?

[ferdnyc]

As I've said, it would also be good to add actual tests for the new code. But I figure first I need to get the tests working without testing the new code, before I worry about adding more tests.

[andyholmes]

This is the section here that controls enabling/disabling actions:

gnome-shell-extension-gsconnect/src/service/plugin.js

Lines 131 to 143 in 97a1287

	connected() {
	// Enabled based on device capabilities, which might change
	const incoming = this.device.settings.get_strv('incoming-capabilities');
	const outgoing = this.device.settings.get_strv('outgoing-capabilities');
	for (const action of this._gactions) {
	const info = this._meta.actions[action.name];
	if (info.incoming.every(type => outgoing.includes(type)) &&
	info.outgoing.every(type => incoming.includes(type)))
	action.set_enabled(true);
	}
	}

So as long as every incoming/outgoing packet type for the action is also in the incoming/outgoing for the device, it will be enabled. So I'd guess what you need is to add kdeconnect.share.request.update to both sides of the test rig.

[ferdnyc]

@andyholmes That seems to have done it, thanks!

Now I just have to gin up some tests for the new code.