Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: ํšŒ์›๊ฐ€์ž…์‹œ ์ด๋ฉ”์ผ ์ค‘๋ณต ๊ฒ€์‚ฌ #336

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

Umjiseung
Copy link
Contributor

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

ํšŒ์›๊ฐ€์ž…์„ ํ•  ๋•Œ ์ด๋ฉ”์ผ ์ธ์ฆ์„ ์กด์žฌํ•˜๋Š” ์ด๋ฉ”์ผ์—๋„ ์ธ์ฆ๋ฉ”์ผ์„ ๋ณด๋‚ด๋Š” ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๊ธฐ ์œ„ํ•ด ์กด์žฌํ•˜๋Š” ์ด๋ฉ”์ผ์ธ์ง€ ๊ฒ€์ฆํ•œ ํ›„์— ์ธ์ฆ ๋ฉ”์ผ์„ ๋ณด๋‚ผ ์ˆ˜ ์žˆ๋„๋ก api๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€์Šต๋‹ˆ๋‹ค

Resolves: #335

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

์กด์žฌํ•˜๋Š” ์ด๋ฉ”์ผ์ธ์ง€ ๊ฒ€์ฆํ•˜๋Š” signUpEmailVerification api๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€์Šต๋‹ˆ๋‹ค

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?
  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ฐœ์ƒํ•œ ๋ณ€๊ฒฝ ์‚ฌํ•ญ์ด Resource ์„œ๋ฒ„์—๋„ ๋ฐ˜์˜๋˜์—ˆ๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@Umjiseung Umjiseung added ๐Ÿ“ฌ API ์„œ๋ฒ„ API ํ†ต์‹  1๏ธโƒฃPriority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ โœจ Feature ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ labels Jun 22, 2024
@Umjiseung Umjiseung self-assigned this Jun 22, 2024
Copy link
Contributor

@KimTaeO KimTaeO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋ฉ”์ผ ์ธ์ฆ์„ ๋ณด๋‚ผ ๋•Œ ์ตœ๋Œ€ ๋ฐœ์†ก ํšŸ์ˆ˜ ์ œํ•œ์„ ๊ฑฐ๋Š” ๋น„์ฆˆ๋‹ˆ์Šค๋‚˜ ์ด๋ฉ”์ผ ์ธ์ฆ์ด ์™„๋ฃŒ ๋˜์—ˆ๋Š”์ง€ ํ™•์ธํ•˜๋Š” ๋น„์ฆˆ๋‹ˆ์Šค๋ฅผ ์ด๋ฏธ ์ด๋ฉ”์ผ ๋ฐœ์†ก API์—์„œ ๊ฒ€์ฆํ•˜๋Š”๋ฐ ์ด API๋ฅผ ํ˜ธ์ถœํ•จ์œผ๋กœ์จ ์–ป์„ ์ˆ˜์žˆ๋Š” ์ด์ ์ด ๋ฌด์—‡์ธ์ง€ ์ž˜ ๋ชจ๋ฅด๊ฒ ์Šต๋‹ˆ๋‹ค.
๋˜ํ•œ ๊ทธ๋Ÿผ์—๋„ ๋ถˆ๊ตฌํ•˜๊ณ  ๋งŒ์•ฝ์— ํ•ด๋‹น API๋ฅผ ์ถ”๊ฐ€ํ•˜๊ฒŒ ๋œ๋‹ค๋ฉด ํŒจํ‚ค์ง€๋ฅผ email ํŒจํ‚ค์ง€๋กœ ์˜ฎ๊ธฐ์ง€ ์•Š์•„์•ผ ํ• ๊นŒ ์‹ถ๋„ค์š”

@Umjiseung
Copy link
Contributor Author

์ด๋ฉ”์ผ ์ธ์ฆ์„ ๋ณด๋‚ผ ๋•Œ ์ตœ๋Œ€ ๋ฐœ์†ก ํšŸ์ˆ˜ ์ œํ•œ์„ ๊ฑฐ๋Š” ๋น„์ฆˆ๋‹ˆ์Šค๋‚˜ ์ด๋ฉ”์ผ ์ธ์ฆ์ด ์™„๋ฃŒ ๋˜์—ˆ๋Š”์ง€ ํ™•์ธํ•˜๋Š” ๋น„์ฆˆ๋‹ˆ์Šค๋ฅผ ์ด๋ฏธ ์ด๋ฉ”์ผ ๋ฐœ์†ก API์—์„œ ๊ฒ€์ฆํ•˜๋Š”๋ฐ ์ด API๋ฅผ ํ˜ธ์ถœํ•จ์œผ๋กœ์จ ์–ป์„ ์ˆ˜์žˆ๋Š” ์ด์ ์ด ๋ฌด์—‡์ธ์ง€ ์ž˜ ๋ชจ๋ฅด๊ฒ ์Šต๋‹ˆ๋‹ค. ๋˜ํ•œ ๊ทธ๋Ÿผ์—๋„ ๋ถˆ๊ตฌํ•˜๊ณ  ๋งŒ์•ฝ์— ํ•ด๋‹น API๋ฅผ ์ถ”๊ฐ€ํ•˜๊ฒŒ ๋œ๋‹ค๋ฉด ํŒจํ‚ค์ง€๋ฅผ email ํŒจํ‚ค์ง€๋กœ ์˜ฎ๊ธฐ์ง€ ์•Š์•„์•ผ ํ• ๊นŒ ์‹ถ๋„ค์š”

์ผ๋‹จ ์ด API์˜ ์šฉ๋„๋Š” ์ด๋ฉ”์ผ ์ธ์ฆ์„ ํ•˜๊ธฐ ์ „์— ์ด๋ฏธ ์กด์žฌํ•˜๋Š” ์ด๋ฉ”์ผ์ธ์ง€ ํ™•์ธํ•˜๊ณ  ์ด๋ฉ”์ผ ์ธ์ฆ์„ ํ•˜๊ธฐ ์ „์— ๋ถˆํ•„์š”ํ•œ ์ด๋ฉ”์ผ ์ธ์ฆ ๊ณผ ํšŒ์›๊ฐ€์ž…์‹œ์— ์กด์žฌํ•˜๋Š” ์ด๋ฉ”์ผ์— ์ธ์ฆ ์ด๋ฉ”์ผ์„ ๊ฐ€๊ฒŒ ํ•˜๋Š” ๊ฒƒ์€ ์ข‹์ง€ ์•Š๋‹ค๊ณ  ์ƒ๊ฐํ•˜์—ฌ ํšŒ์˜๋ฅผ ์ง„ํ–‰ํ•˜๋ฉด์„œ ์ƒ๊ฐํ•œ ๋ฐฉ๋ฒ•์ด ์ด API์ž…๋‹ˆ๋‹ค.
์œ„์—์„œ ๋ง์”€ํ•ด์ฃผ์‹  ์ด๋ฉ”์ผ ์ธ์ฆ ๋น„์ฆˆ๋‹ˆ์Šค๋“ค๊ณผ๋Š” ์กฐ๊ธˆ ๋‹ค๋ฅด๋‹ค๊ณ  ์ €๋Š” ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค.
๋ง์”€ํ•ด์ฃผ์‹  API๋Š” ์ด๋ฉ”์ผ ์ธ์ฆ๊ณผ ๊ด€๋ จ๋œ ๊ฒƒ์ด์ง€๋งŒ ์ด API๋Š” ๊ทธ ์ „ ๋‹จ๊ณ„์ธ ์ค€๋น„๋‹จ๊ณ„์™€ ๋น„์Šทํ•˜๋‹ค๊ณ  ์ƒ๊ฐํ•ด์š”

Copy link
Contributor

@KimTaeO KimTaeO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ทธ๋ ‡๋‹ค๋ฉด ์ฐจ๋ผ๋ฆฌ ์ €๊ฑธ Email ์ธ์ฆ ๋ฐœ์†ก ์‹œ์— ๊ฒ€์ฆํ•˜๋Š”๊ฒŒ ํ›จ์”ฌ ๋‚ซ์ง€ ์•Š์„๊นŒ ์‹ถ๋„ค์š”

@Umjiseung
Copy link
Contributor Author

๊ทธ๋ ‡๋‹ค๋ฉด ์ฐจ๋ผ๋ฆฌ ์ €๊ฑธ Email ์ธ์ฆ ๋ฐœ์†ก ์‹œ์— ๊ฒ€์ฆํ•˜๋Š”๊ฒŒ ํ›จ์”ฌ ๋‚ซ์ง€ ์•Š์„๊นŒ ์‹ถ๋„ค์š”

์›๋ž˜ ๊ทธ๋Ÿด๋ ค๊ณ  ํ–ˆ๋Š”๋ฐ ์ œ๊ฐ€ ์•Œ๊ธฐ๋ก  ๋น„๋ฐ€๋ฒˆํ˜ธ ์ฐพ๊ธฐ๋ฅผ ํ•  ๋•Œ๋„ ์ด๋ฉ”์ผ ์ธ์ฆ์„ ํ•˜๋Š” ๊ฑธ๋กœ ์•Œ์•„์„œ ๊ทธ ๋กœ์ง์— ์ถ”๊ฐ€ํ•˜๋ฉด ์•ˆ๋  ๊ฑฐ ๊ฐ™์•„์„œ ๋”ฐ๋กœ API๋ฅผ ์ถ”๊ฐ€ํ•˜๊ฒŒ ๋œ ๊ฑฐ์—์š”

@Umjiseung Umjiseung merged commit 5cbaa7e into main Jun 23, 2024
1 check passed
@Umjiseung Umjiseung deleted the feature/335-signup-email-verification-duplication branch June 23, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1๏ธโƒฃPriority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ ๐Ÿ“ฌ API ์„œ๋ฒ„ API ํ†ต์‹  โœจ Feature ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ
Projects
None yet
2 participants