This repository has been archived by the owner on Dec 7, 2024. It is now read-only.
๐ย :: ์์ ์ ์ถ์ ์ํ ์กฐํ #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ta2ye0n
requested review from
louis7308,
Huuuunee,
dolong2 and
yoonjibin
as code owners
KimTaeO
reviewed
Apr 26, 2024
src/main/kotlin/com/msg/gcms/domain/attendance/service/impl/FindAttendSelfCheckServiceImpl.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/msg/gcms/domain/attendance/service/impl/FindAttendSelfCheckServiceImpl.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| val period = getCurrentPeriod() | ||
| val attend = attendanceRepository.findByPeriodAndUser(period, user) |
There was a problem hiding this comment.
๋ง์ฝ์ ์ด๋ ๊ฒ ์ฟผ๋ฆฌ๋ฅผ ๋ ๋ฆฌ๊ฒ ๋๋ค๋ฉด NonUniqueResultException์ด ๋ฐ์ํ ๊ฒ ๊ฐ๋ค์
ํ์ฌ ๋ ์ง๋ฅผ ๊ธฐ์ค์ผ๋ก Schedule ์ํฐํฐ๋ฅผ ์ฐพ์์์ Attendace๋ฅผ findํ๋ ์ฟผ๋ฆฌ๋ฅผ ๋ ๋ฆด ๋ ์กฐ๊ฑด์ผ๋ก ์ถ๊ฐํ๋ ์์ผ๋ก ํด๊ฒฐํด๋ ์ข์ ๊ฒ ๊ฐ์์
There was a problem hiding this comment.
์์ ํ์ต๋๋ค
ani2689
reviewed
Apr 26, 2024
src/main/kotlin/com/msg/gcms/domain/attendance/service/FindAttendSelfCheckService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/msg/gcms/domain/attendance/presentation/AttendanceController.kt
Outdated
Show resolved
Hide resolved
Umjiseung
reviewed
Apr 26, 2024
Comment on lines
5
to
7
| data class AttendSelfCheckResponseDto( | ||
| val attendanceStatus: AttendanceStatus | ||
| ) |
There was a problem hiding this comment.
๋ค์ฌ์ฐ๊ธฐ๊ฐ ๋๋ฌด ๋ง์ด ๋๊ฒ๊ฐ์์!
There was a problem hiding this comment.
์์ ํ์ต๋๋ค
Comment on lines
16
to
21
| class FindAttendSelfCheckServiceImpl ( | ||
| private val userUtil: UserUtil, | ||
| private val attendanceRepository: AttendanceRepository, | ||
| private val clubRepository: ClubRepository, | ||
| private val attendanceConverter: AttendanceConverter | ||
| ): FindAttendSelfCheckService { |
There was a problem hiding this comment.
์ฌ๊ธฐ๋ ๋ค์ฌ์ฐ๊ธฐ๊ฐ ๋ง์ด ๋๊ฒ๊ฐ์์ฉ
โฆndAttendSelfCheckServiceImpl.kt Co-authored-by: ๊นํ์ค <103710151+KimTaeO@users.noreply.github.com>
โฆendSelfCheckService.kt Co-authored-by: ๋ ธํ์ฃผ <106813267+ani2689@users.noreply.github.com>
โฆtendanceController.kt Co-authored-by: ๋ ธํ์ฃผ <106813267+ani2689@users.noreply.github.com>
Umjiseung
approved these changes
Apr 26, 2024
KimTaeO
reviewed
Apr 26, 2024
src/main/kotlin/com/msg/gcms/domain/attendance/service/impl/FindAttendSelfCheckServiceImpl.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/msg/gcms/domain/attendance/service/impl/FindAttendSelfCheckServiceImpl.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐ์
์ ์๋๊ป์ ์ด๋ฐ ๊ธฐ๋ฅ์ด ์์ผ๋ฉด ์ข๊ฒ ๋ค๊ณ ํ์ จ๊ธฐ ๋๋ฌธ์ ๋๋ค
Resolves: #347
๐ ์์ ๋ด์ฉ
๋ณธ์ธ์ ์ถ์ ์ํ ์กฐํ ๊ธฐ๋ฅ๋ฅผ ๊ตฌํํ์์ต๋๋ค
โ PR ์ฒดํฌ๋ฆฌ์คํธ
.env,๋ ธ์ ,README)"API ๊ฐ๋ฐ ์๋ฃ๋์ด์","ํ๊ฒฝ๊ฐ ์ถ๊ฐ๋์์ด์")๐ธ ๊ธฐํ