Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

andy/216-redesign-pages-fix-reloading #218

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

andyvo2004
Copy link
Contributor

@andyvo2004 andyvo2004 commented Oct 7, 2024

216

Issue Number(s): #216 .

What does this PR change and why?

  • Pause button component updated to reflect Figma and contain timer
  • Pause page redesigned to reflect Figma
  • Math page redesigned to reflect Figma
  • Trivia page redesigned to reflect Figma
  • Reset attempted every time app is opened
  • Add extra time functionality

Checklist

  • Math Pages Updated
  • Trivia Pages Updated
  • Pause Page Updated
  • Refresh analytics more frequently.

Critical Changes / Notes

  • Math equations may overflow box (decrease font size?)
  • Trivia may overflow page (decrease vertical padding?)
  • I was not able to implement the shadows from the Figma.
  • Extra time functionality only in Math and Trivia while Shivani works on Writing and Reading

Related PRs

  • None

Testing

Go through each page to ensure it correctly reflects the Figma redesigns. Ensure each page redirects correctly. Go through math and trivia questions to ensure there is no overflow in the design. Watch count down to ensure extra time is displayed properly.

Copy link

github-actions bot commented Oct 7, 2024

🚀 Expo preview is ready!

  • Project → brain-exercise
  • Platforms → android, ios
  • Scheme → myscheme
  • Runtime Version → 1.0.0
  • More info

Learn more about 𝝠 Expo Github Action

Copy link
Contributor

@johannesq23 johannesq23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@johannesq23 johannesq23 merged commit 0ae9169 into develop Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants