No more TESR on conduits #176
Merged
+40
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change completely removes the TESR for all conduits. The TESR was only actually used by the basic fluid conduit to render the fluid texture inside the conduit, this is mostly entirely unnecessary and can be rendered via the ISBRH.
All conduits other than the basic fluid conduit are completely unchanged by this, and as of writing there is a minor change to the rendering of the basic fluid conduit. The first image below is the original rendering with the TESR, the second image is the new rendering from ISBRH. The only different is that I'm not sure how to make it not darken the top(I also can't tell how the TESR is doing this either).
The advantage of this change is that currently the TESR, while largely unused, is still implemented for every single conduit, meaning that the rendering loop for TESRs has to waste time going through each conduit, even if it's ultimately just going to do some checks and then not render anything.