Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a coke oven crash caused by recipes with no fluid output #49

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

antihutka
Copy link

Putting a wood pellet into a Railcraft coke oven crashes the server. Add a null check for the recipe's fluid output to fix the issue.

@Dream-Master
Copy link
Member

@antihutka you need to run upgrade buildscript. Your build failed

@Dream-Master Dream-Master requested a review from a team November 5, 2023 11:44
@antihutka
Copy link
Author

Done. Updating both buildscript and dependencies was required, and I had to disable checkstyle to get it to build - there are too many .* imports all over the place, that would have to be cleaned up separately.

@Dream-Master
Copy link
Member

@antihutka the cleanup can be made with idea as an example.

@antihutka
Copy link
Author

Done.

@bombcar bombcar merged commit fd50c86 into GTNewHorizons:master Nov 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants