Replace pearl returns with Enhanced Infusion Recipe#6
Merged
Dream-Master merged 9 commits intomasterfrom Feb 15, 2026
Merged
Conversation
LazyFleshWasTaken
added
enhancement
Member
|
server run not work |
…gotta have it defined
Dream-Master
added
the
🚧 Testing on Zeta
Contributor
|
Let’s just move the pearl out from the central pillar and make everything work without any jank. That sounds like the easiest solution, and without any chance for pearl duplication. |
Contributor
Author
|
new recipes: (mostly swapped the mixed crystal cluster with the prime pearl, and have 2 recipes for the thaumotruge's ring, one with earth, one with sky in the centre) |
Contributor
Contributor
Ethryan
approved these changes
Feb 15, 2026
Contributor
Ethryan
left a comment
Ethryan
left a comment
There was a problem hiding this comment.
This looks fine, don’t know why it errors though.
Contributor
Author
I cant say either. It works properly in both dev env and full pack maybe its just something with the dependencies on the action? |
Dream-Master
removed
the
🚧 Testing on Zeta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace with eir where needed, remove listener for crafting event, and update deps.
Problem: the dev env cannot run due to some exception with thaumcraft nei plugin, and so this couldn't be tested in dev env.needs explicit dependency on thaum nei plugin, cant be from a transitive dep (through thauimic energstics)Full pack crashes, too, but it points to gtnh coremod as the cause instead.someone renamed the class and the method to get an item from coremod >:(went from import com.dreammaster.gthandler.CustomItemList; to import com.dreammaster.item.NHItemList, and the method went from getIS() on 2.8.51 to get() on 2.8.142.
Anyway, runs in full pack, and the pearl return worked for master's rings.
Unfortunately, I overlooked that the pearl is in the central slot of the combination rings, and therefore cannot be returned with this method. Ugh.
Or well, not without a little jank. I can replace the last (unique) item to be absorbed instead, but that opens up the possibly of duping pearls by canceling the recipe right after the conversion but before the central item is transformed.
How do you want to handle this, @Ethryan ? New recipes or a bit of barely noticeable jank? (assuming people have WA on the matrix by the time they get to the higher rings)
addresses: GTNewHorizons/GT-New-Horizons-Modpack#23495 (comment)
crash report from dev env:
crash-2026-02-14_00.29.40-client.txt