Open
Conversation
Collaborator
mitchej123
commented
Mar 14, 2026
mitchej123
commented
- Stop re-calculating spawn cap each tick; cache count every ~40 ticks
- Use TLongHashSet instead of HashMap<ChunkCoordIntPair, Boolean> for eligible chunk counting - allocation/boxing free
- Cache Monument Bounding Boxes and refresh periodically (~5m), avoids constant scanning/parsing of NBT
* Stop re-calculating spawn cap each tick; cache count every ~40 ticks * Use TLongHashSet instead of HashMap<ChunkCoordIntPair, Boolean> for eligible chunk counting - allocation/boxing free * Cache Monument Bounding Boxes and refresh periodically (~5m), avoids constant scanning/parsing of NBT
Sopel97
reviewed
Mar 15, 2026
src/main/java/astrotibs/villagenames/prismarine/guardian/spawning/SpawnEventListener.java
Outdated
Show resolved
Hide resolved
mitchej123
requested review from
Alexdoru and
Sopel97
and removed request for
Sopel97
Dream-Master
added
the
🚧 Testing on Zeta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.