Adding Advanced Wireless Setup Kit #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found a potential issue - marking as draft until I resolve it or confirm it's not an issue |
|
Seems like the issue was a result of a bad build - unmarking as draft |
5 tasks
5 tasks
Laiff
requested changes
Jun 11, 2024
src/main/scala/net/bdew/ae2stuff/misc/AdvItemLocationStore.scala
Outdated
Show resolved
Hide resolved
src/main/scala/net/bdew/ae2stuff/misc/AdvItemLocationStore.scala
Outdated
Show resolved
Hide resolved
- Added constants to AdvWirelessKit.scala to define values for the modes - Added a constant to AdvItemLocationStore.scala to find the NBTTag type and use that in place of which was used previously - Added error logging to AdvWirelessKit.scala and ItemWirelessKit.scala for when a connection fails fatally - Switched else statements for mode to else if statements to explicitly check that the mode is the other mode
- Added constants to AdvWirelessKit.scala to define values for the modes - Added a constant to AdvItemLocationStore.scala to find the COMPOUND NBTTag type and use that in place of 10 which was used previously - Added error logging to AdvWirelessKit.scala and ItemWirelessKit.scala for when a connection fails fatally - Switched else statements for mode to else if statements to explicitly check that the mode is the other mode
Laiff
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Advanced Wireless Setup Kit, a tool aimed to ease the pain of binding many wireless connectors at once. It allows you to queue wireless connectors to be bound, and then bind them all in one go.
Has two modes
Sneak right click to change the mode of the tool.
Can be put in a crafting table to clear the NBT, which effectively will clear the queue as well to remove any left over/stale connectors
If anyone can come up with a better texture be my guest, I'm not great at sprite design.
Recipe PR here: GTNewHorizons/NewHorizonsCoreMod#864
Video of it in action:
https://github.com/GTNewHorizons/ae2stuff/assets/16232674/7748b4c6-96c3-448b-b0f8-f013d367be74
*misc addition is that I added an NBT clearing recipe for the normal wireless setup kit too, since sometimes it's hard to tell if that one is currently bound to a connector or not