RenderMan render pass type adaptors #6317
Conversation
As we're about to include RenderMan in the mix, this ends up being simpler than accounting for the quirks of each renderer's handling of the default camera. The `samples` option in the Cycles render has been adjusted to ensure we sample a less noisy pixel with the new camera.
This adds support for our standard `reflection`, `reflectionAlpha` and `shadow` render pass types. The skipped `testReflectionCasterLightLinks` should be removed once we support light linking.
|
Hmm. Looks like we're running into issues running repeated RenderMan renders, such as those in RenderPassAdaptorTest. I've pushed another commit 4037e52 adding a test in RenderManRenderTest that runs 10 renders of a simple scene containing a cube with no lights or shaders, and it also crashes in libprman.so. https://github.com/GafferHQ/gaffer/actions/runs/13867615532/job/38809712360?pr=6317#step:14:1537 If I increase the iterations to 50 then I start seeing that test randomly fail on my workstation, or succeed but then crash on shutdown, or succeed with no issue. Changing the test to render to a new file per iteration doesn't appear to make a difference. |
johnhaddon
force-pushed
the
renderManRenderPassTypeAdaptors
branch
from
837b8c9 to
e4283c5
Compare
I've pushed a fix for that in e4283c5, and Daniel has checked it over for me - merging. For 1.6 I'm tempted to make some changes to our Renderer API so we can avoid some of these workarounds, but this will keep us moving for now. |
This adds support for our standard
reflection,reflectionAlphaandshadowrender pass types. The skippedtestReflectionCasterLightLinkstest should be removed once we support light linking.