GafferScene : Add ShuffleRenderPasses node#6332
GafferScene : Add ShuffleRenderPasses node#6332johnhaddon merged 2 commits intoGafferHQ:1.5_maintenancefrom
Conversation
a5950a2 to
409a092
Compare
johnhaddon
left a comment
There was a problem hiding this comment.
Thanks Murray, this is fun (in a mind-boggling sort of way!).
it likely hastens the need for inspecting the history of a particular render pass and for warnings in the Render Pass Editor if you attempt to edit a shuffled render pass in an edit scope upstream of its originating ShuffleRenderPasses node...
Yeah, anything we can do to help folks navigate the context switch will be very worthwhile. I was pleased to see that the active row highlighting for RenderPassOptions spreadsheets shows you the source row when viewing upstream of a shuffle, so we already have some diagnostics in place. I think it's OK to roll out without further diagnostics, with the intention of starting a dialogue with a few power users as to how this might fit into their workflows.
For the edit warning, it seems like we need Inspector::acquireEdit() to also provide the context at that point in the graph? Oh, but maybe we can get that straight from the ContextTracker? And if $renderPass differs from the current value, display it? I think this might be one of those ones that comes across better as Info than Warning - something like this?
ℹ️ Editing source render pass foo
Maybe that's not too hard to achieve?
409a092 to
1666647
Compare
1666647 to
c1202b2
Compare
|
Thanks Murray - squashed and merged. |
This adds a ShuffleRenderPasses node allowing procedural renaming and copying of render passes.
Shuffling a render pass updates the contents of the
renderPass:namesoption in the scene output by the node, and remaps the value of the${renderPass}context variable upstream of the node. This node opens up new workflows where users can create "child" or "derived" render passes that inherit their settings from an upstream render pass, though it likely hastens the need for inspecting the history of a particular render pass and for warnings in the Render Pass Editor if you attempt to edit a shuffled render pass in an edit scope upstream of its originating ShuffleRenderPasses node...