Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoke feature #34

Merged
merged 7 commits into from
Sep 6, 2024
Merged

Revoke feature #34

merged 7 commits into from
Sep 6, 2024

Conversation

humorless
Copy link
Member

@humorless humorless commented Sep 5, 2024

Setup

  • create some testing code, which can create 10 testing accounts with username and avatar.
    • The file repl-sessions/revoke.clj

UI part

  • disable editing profile because currently profile details page is still not good.
  • create a basic layout with contact list and button to revoke the connection.
  • use person-remove icon
  • image shows username when hovering
  • icon changes background color when hovering

Behavior part

  • click the button to remove the connection
  • refresh the UI to reflect the state change

first attempt to do the layout

截圖 2024-09-06 上午12 12 08

@plexus plexus marked this pull request as ready for review September 6, 2024 08:41
@plexus plexus merged commit 9bd3ebf into main Sep 6, 2024
1 check failed
@plexus plexus deleted the laurence/revoke branch September 6, 2024 08:41
@plexus
Copy link
Member

plexus commented Sep 6, 2024

Merging so I can better test and review.

@plexus
Copy link
Member

plexus commented Sep 6, 2024

Ok, some feedback

This shouldn't be under "Profile", make a separate /contacts route that shows your list of contacts. Keep in mind that this is private information, so it doesn't make sense to have it be part of Profile.

Make sure you have a navigation item for "Contacts".

We should have a visible button on that page for "Add contact" as well as in the sidebar.

On that contacts page we want to show at a minimum a person's name, but probably more as well, like discord username, links. It should be more a vertical list then this horizontal list/grid that you have now.

@plexus
Copy link
Member

plexus commented Sep 6, 2024

It's always good to look around first at prior art

2024-09-06_105529
2024-09-06_105510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants