Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

Fitters to Samples of the Potential #20

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Fitters to Samples of the Potential #20

merged 2 commits into from
Jan 20, 2021

Conversation

nstarman
Copy link
Collaborator

@nstarman nstarman commented Dec 25, 2020 •
edited
Loading

Description

Make a package-agnostic architecture for fitting an orthogonal expansion form of the potential given sample points.

The main class is both the base class and also the main class used to initialize a fitter. It uses a registry system to auto-determine the package of the fit method and create an instance of the fit class registered for that package. It can either return that specific class, or not, in which case it stores the instance and directs all calls to it.

fit_method = package.fit_method

fitter = Fitter(fit_method)

Signed-off-by: Nathaniel Starkman (@nstarman) nstarkman@protonmail.com

PR Checklist

  • Check out the contributing guidelines and code of conduct
  • Check out the contributing workflow ( for a practical example click here )
  • Give a detailed description of the PR above.
  • Document changes in the TEMPLATE_CHANGES.md file. See existing changelog for examples.
  • Add tests, if applicable, to ensure code coverage never decreases.
  • Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.
  • Ensure linear history by rebasing, when requested by the maintainer.

@nstarman nstarman added this to the v0.1 milestone Dec 25, 2020
@nstarman nstarman added the enhancement New feature or request label Dec 25, 2020
@nstarman nstarman marked this pull request as draft December 25, 2020 22:06
@nstarman
fit stuff
c9a8975 
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>

# Conflicts:
#	discO/__init__.py
#	discO/common.py
#	discO/core/__init__.py
#	discO/core/core.py
@codecov
Copy link

codecov bot commented Jan 16, 2021 •
edited
Loading

Codecov Report

Merging #20 (5dff71a) into master (4f4a865) will decrease coverage by 7.33%.
The diff coverage is 70.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   91.05%   83.71%   -7.34%     
==========================================
  Files          14       16       +2     
  Lines         313      436     +123     
==========================================
+ Hits          285      365      +80     
- Misses         28       71      +43
Impacted Files Coverage Δ
discO/plugin/agama/__init__.py 0.00% <0.00%> (ø)
discO/plugin/agama/fitter.py 0.00% <0.00%> (ø)
discO/plugin/agama/sample.py 0.00% <0.00%> (ø)
discO/core/__init__.py 100.00% <100.00%> (ø)
discO/core/core.py 100.00% <100.00%> (ø)
discO/core/fitter.py 100.00% <100.00%> (ø)
discO/core/measurement.py 100.00% <100.00%> (ø)
discO/core/sample.py 100.00% <100.00%> (ø)
discO/plugin/galpy/sample.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f4a865...5dff71a. Read the comment docs.

@github-actions github-actions bot added the Docs label Jan 19, 2021
@nstarman
Copy link
Collaborator Author

nstarman commented Jan 19, 2021 •
edited
Loading

@CCAstro35, ready for review. low codecov because #21 . Otherwise it's done and works well.

@nstarman nstarman marked this pull request as ready for review January 19, 2021 21:14
@nstarman nstarman requested a review from CCAstro35 January 19, 2021 21:15
@nstarman
Copy link
Collaborator Author

I got the fit method to work on the multi-dimensional SkyCoord outputs from sample.

@nstarman
fit on multidimensional
5dff71a 
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@nstarman nstarman mentioned this pull request Jan 19, 2021
Closed
7 tasks
CCAstro35
CCAstro35 approved these changes Jan 20, 2021
View reviewed changes
Copy link
Collaborator

@CCAstro35 CCAstro35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nstarman nstarman merged commit 33b20a7 into master Jan 20, 2021
@nstarman nstarman mentioned this pull request Jan 20, 2021
Open
3 tasks
@nstarman nstarman deleted the fit_stuff branch January 22, 2021 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CCAstro35 CCAstro35 CCAstro35 approved these changes

Assignees

@nstarman nstarman

@CCAstro35 CCAstro35

Labels
Docs enhancement New feature or request
Projects
None yet
Milestone
v0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nstarman @CCAstro35