Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace uses of imperative SHA2 with spec-adherent SHA2 #122

Open
3 tasks done
marsella opened this issue Aug 23, 2024 · 0 comments · May be fixed by #224
Open
3 tasks done

Replace uses of imperative SHA2 with spec-adherent SHA2 #122

marsella opened this issue Aug 23, 2024 · 0 comments · May be fixed by #224
Assignees
@marsella
Labels
CNSA 2.0 improvement Addresses fixes or changes to existing specs

Comments

@marsella
Copy link
Contributor

marsella commented Aug 23, 2024 •
edited
Loading

Several spots throughout the code use the imperative version of SHA2, instead of the more obviously-spec-adherent version added in #112. We should try to replace these with the spec version.

Optional: maybe block on #98 in case some of these uses are actually generic over the hash?

  • Identify all uses and determine which need the imperative version specifically
  • Decide whether to remove the imperative version. If not, add a README explaining when to use each version. If so, delete it.
  • Add notes to SHA-2 spec that it'll be eventually superseded by SHA-3 I'm not going to do this.
@mccleeary-galois mccleeary-galois added enhancement New feature or request CNSA 2.0 labels Aug 29, 2024
@marsella marsella added improvement Addresses fixes or changes to existing specs and removed enhancement New feature or request labels Aug 29, 2024
@marsella marsella self-assigned this Jan 23, 2025
marsella added a commit that referenced this issue Jan 23, 2025
@marsella
rsa-pss: update with new sha2 implementation #122
4ae5dbb 
- adds some type constraints to accommodate the message length limits in
  sha2
marsella added a commit that referenced this issue Jan 23, 2025
@marsella
hmac: replace SHA2 with new instantiation #122
768a60b 
Also adds a test vector.
marsella added a commit that referenced this issue Jan 23, 2025
@marsella
hkdf: fix constraints to match hmac #122
a6c53e9 
Adjusting to match the underlying SHA2 requirement
Also this accidentally changes the newline format from CRLF to LF
marsella added a commit that referenced this issue Jan 23, 2025
@marsella
sha2: rename version that reveals internals #122
179ba2b
marsella added a commit that referenced this issue Jan 23, 2025
@marsella
sha2: add equivalence proof of sha2 versions #122
a723644
marsella added a commit that referenced this issue Jan 23, 2025
@marsella
hash: update README for hash functions #122
6dfaebc
@marsella marsella linked a pull request Jan 23, 2025 that will close this issue
Open
marsella added a commit that referenced this issue Jan 23, 2025
@marsella
sha2: fix copyright notices, spacing, on deps #122
78a6cb5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marsella marsella

Labels
CNSA 2.0 improvement Addresses fixes or changes to existing specs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SHA2: Use new version where possible GaloisInc/cryptol-specs
2 participants
@marsella @mccleeary-galois