SHA2: Use new version where possible #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds some type constraints to accommodate the message length limits in sha2
Also adds a test vector.
Adjusting to match the underlying SHA2 requirement Also this accidentally changes the newline format from CRLF to LF
Merged
mccleeary-galois
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #122.
I looked through all the uses of the alternative SHA2 implementation and replaced most of them with the spec-adherent version. The remaining applications use some internal functions that aren't public in the spec-adherent version and which I'm not particularly inclined to make public without looking through the specs for the other applications.
I chose to keep the alternative SHA2 version and rename it
SHA2Internal. I documented the uses in the hash readme. I'm also open to deleting it and all its dependencies -- an implementation of SHACAL and one of HMAC. (There are two versions of HMAC in the repo, one of which I was able to switch to use the spec-adherent SHA2 -- see also #157)