CI: Build ubuntu-24.04-arm binaries
#60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mysteriously, GitHub Actions' Ubuntu 22.04 runners have `libreadline-dev` installed by default, but their Ubuntu 24.04 runners do not, which causes `abc` to fail to build on Ubuntu 24.04 runners. Let's make sure to install `libreadline-dev` explicitly to ensure that it is always available for `abc`'s benefit.
This backports a fix for a CVC4 issue (described in cvc5/cvc5#10591), which causes bash-5.2 (which Ubuntu 24.04 uses) to spuriously replace uses of ampersands (&) in text replacement. This patch was accumulated from the following CVC5 pull requests: * cvc5/cvc5#9233 * cvc5/cvc5#9330 * cvc5/cvc5#9338 Previously, these changes were also included as part of `patches/cvc4-win64-native.patch` (which is only applied on Windows), but we now split these changes out into a separate patch so that Ubuntu 24.04 can make use of them.
One of the key motivators for doing so is that building `bitwuzla-0.3.0` on AArch64 Ubuntu 24.04 (see #50) yields a broken binary that cannot even run `problems/multi_dist.smt2`.
This adds CI jobs that build Ubuntu 24.04 binaries for arm64 in addition to x86-64. This leverages the newly added GitHub Actions runners for arm64 Ubuntu (see https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/). Fixes #50.
RyanGlScott
force-pushed
the
T50-ubuntu-arm
branch
2 times, most recently
from
a500f67 to
748e693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds CI jobs that build Ubuntu 24.04 binaries for arm64 in addition to x86-64. This leverages the newly added GitHub Actions runners for arm64 Ubuntu (see https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/).
Fixes #50. This is built on top of the changes from #56 (and therefore this supersedes #56).