perf(core): update username index (#4614)

* perf(core): update username index * fix: index filter expression
GaloyMoney · Oct 18, 2024 · 69c2045 · 69c2045
1 parent 7c32599
commit 69c2045
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/core/api/src/services/mongoose/accounts.ts b/core/api/src/services/mongoose/accounts.ts
@@ -1,4 +1,4 @@
-import { caseInsensitiveRegex, parseRepositoryError } from "./utils"
+import { parseRepositoryError } from "./utils"
 
 import { AccountStatus } from "@/domain/accounts"
 import {
@@ -44,7 +44,9 @@ export const AccountsRepository = (): IAccountsRepository => {
     username: Username,
   ): Promise<Account | RepositoryError> => {
     try {
-      const result = await Account.findOne({ username: caseInsensitiveRegex(username) })
+      const result = await Account.findOne({ username })
+        .collation({ locale: "en", strength: 2 })
+        .hint({ username: 1 })
       if (!result) {
         return new CouldNotFindAccountFromUsernameError(username)
       }

diff --git a/core/api/src/services/mongoose/schema.ts b/core/api/src/services/mongoose/schema.ts
@@ -202,13 +202,18 @@ const AccountSchema = new Schema<AccountRecord>(
 
     username: {
       type: String,
-      match: [UsernameRegex, "Username can only have alphabets, numbers and underscores"],
+      match: [
+        UsernameRegex,
+        "Username can only have alphabets, numbers, and underscores",
+      ],
       minlength: 3,
       maxlength: 50,
       index: {
         unique: true,
         collation: { locale: "en", strength: 2 },
-        partialFilterExpression: { username: { $type: "string" } },
+        partialFilterExpression: {
+          username: { $type: "string", $exists: true },
+        },
       },
     },
     contactEnabled: {