updated to PM4 #84
Open
updated to PM4 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VixikHD
requested changes
May 29, 2022
| @@ -1,5 +1,5 @@ | |||
| name: SkyWars | |||
| api: 3.0.0 | |||
| api: 4.0.0 | |||
| version: 1.2.1 | |||
There was a problem hiding this comment.
Suggested change
| version: 1.2.1 | |
| version: 1.3.0-beta1 |
There was a problem hiding this comment.
In order to update plugin on poggit it is required to increase the version
There was a problem hiding this comment.
Also you should mention yourself in authors field
|
|
||
| if(!$signPos->getLevel() instanceof Level || is_null($this->plugin->level)) return; | ||
| if(!$signPos->getWorld() instanceof World || is_null($this->plugin->level)) return; |
There was a problem hiding this comment.
Position->getWorld() no longer returns null and is always of World instance
Suggested change
| if(!$signPos->getWorld() instanceof World || is_null($this->plugin->level)) return; | |
| if(!$signPos->getWorld()->isLoaded() || is_null($this->plugin->level)) return; |
Update ArenaScheduler.php
Smorted
approved these changes
Apr 3, 2023
|
Sorry for the late answer, i will add the requested changes tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.