Conversation
…sses in spartan.yaml new file: ScannerBit/include/gambit/ScannerBit/scanners/diver_1.3.0/diver.hpp new file: ScannerBit/src/scanners/diver_1.3.0/diver.cpp modified: cmake/scanners.cmake modified: config/scanner_locations.yaml.default modified: yaml_files/spartan.yaml
modified: ScannerBit/src/scanners/diver_1.3.0/diver.cpp
modified: ScannerBit/src/scanners/diver_1.3.0/diver.cpp
…hich parameters they set, and therefore which parameters need to be specified in order to use theire inverse_transform method. Also updated Diver 1.3 interface to use getSetParameters as a more robust way of checking that the parameters provided by the user as initial guesses are the same as those being scanned. modified: ScannerBit/include/gambit/ScannerBit/base_prior.hpp modified: ScannerBit/include/gambit/ScannerBit/priors/composite.hpp modified: ScannerBit/src/priors/composite.cpp modified: ScannerBit/src/scanners/diver_1.3.0/diver.cpp
|
Thanks for doing this so quickly, @patscott! Looks good to me, and works as expected in the tests I've done. If I understand the complication with the gambit/ScannerBit/include/gambit/ScannerBit/py_module_scan.hpp Lines 865 to 870 in d504a2f I'll hold off merging this until you've had a chance to give a thumbs up/down for that addition. (The follow-up task of testing how the various current Python scanners currently work/fail with the |
|
Perfect, thanks! |
This MR adds an interface to Diver 1.3.0.
This includes adding a new yaml option to the Diver scanner to allow the user to pass initial guesses to the scanner. The new option is now demonstrated in
spartan.yamlAlso included in this MR is a new
getSetParametersvirtual function in theScannerBit::BasePriorclass, for checking precisely which parameters priors set, and therefore which parameters need to be specified in order to use theirinverse_transformmethod successfully. For many priors this will just be the same asgetParameters, but for thecompositeprior in particular things get more complicated, and it becomes necessary to differentiate betweengetSetParameters),getParameters), andgetShownParameters).The difference between these is not important for the example in this PR, but it is crucial for the example in the matching GAMBIT_light PR.