-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add web support #120
Conversation
Check readme for known issues
so you tried and port our app to flutter web?! |
Yep, it runs now in Chrome :) The key changes for this are using platform conditional imports for The hardest part was actually realizing I needed to use the Serial api on web and not the USB api ;) |
sooo.... theres some stuff to fix (when just running it in chrome), importing cards or dictionaries doesnt work, read card does, but as you said, the recovery doesnt work (correct me if im wrong but, couldnt one in theory just do a dictionary attack, that should work, right?) , Mfkey32 doesnt work or the page doesnt get updated / its always on "disable collection"... and its kinda slow, but thats fine ig... (the settings work atleast :) ) |
thanks for the pr though :) (cool that someone else also works on stuff) |
|
cool. So:
So, thanks for the help, ill prob host it on my server then, when it gets merged. IDK if its possible, but it might make sense to check for browser and display a "sorry, unsupported browser" message when using none chromium based browsers? (idk if flutter does it by itself, or if it has to be implemented manually or if its even possible to check, but thats some small stuff like the "None" text ;) ) |
and if you feel like it, feel free to add me on discord and i might add you as a contributor? |
oh and dfu afaik also has a fallback to download from releases? anyways, it shouldnt just return a error but a "unsupported" message or smthng ;) and the favicon should point to the logo... but now thats more or less nitpicking |
BTW pages sometimes hangs even on BLE, maybe core issue is there. Not high priority to debug it |
And also regardless README: |
That's great. I've also experimented with standalone web GUI ( React+TS ) and end up connecting via Web Serial API ( saw how they did it in Flipper Lab and abandoned the Web USB API. Saw that Ultra and Lite are using the same Also, is it possible in Flutter to move some of the login in service worker, this would speed things up. |
you awnser those questions ;) |
Thanks, I guess the next best option would be to test for reader mode and not display device info till then. |
feat: add monospaced font to beautify displaying keys in dict fix: better indicate that editting cards/dict is not yet supported
…always showing ultra
And it tires to load lite firmware on my ultra and as expected fails with DFUResponseCode.invalidSignature |
And about that: as we can't know what chumleon user has... left flashing only after connecting, don't discover DFU devices in main menu |
I will do other small changes myself when you will fix those |
PID change for CL: RfidResearchGroup/ChameleonUltra#103 |
@Foxushka Please edit your posts next time and make a list of changes instead of posting 10 comments
|
Nice, but put them back to alert as in main branch |
I define myself as toddler and behave appropriately. And that's generally going to be the case in future too |
@GameTec-live Could you be the tiebreaker here? |
https://aur.archlinux.org/packages/flutter is marked out of date, when it will be updated then we can merge with disabled |
We anyway won't merge without both of us approve that. I will never approve this. |
if it is possible to put back, please do that to keep consistency, but if it isnt possible because of dfu pairing, you can keep it there for web only... |
you still should be able to just run flutter upgrade 🤷 |
My apologies, but I think its for the better to just close this pr. I dont believe it will ever be 'good enough' to merge. Not blaming anybody besides myself for that. @Foxushka My remark above was not super nice either, and for that i want to say sorry. Thats another reason why I think its better I take a step back from the project. Good luck! |
No, no way back |
yes, if he doesnt want to maintain it, this isnt gonna be merged, because we got enough work |
This PR adds first support for Web using the Serial API. I've tried to add minimal changes while making sure nothing is completely broken, hope the changes are still reviewable. If not, let me know and I can try to split the PR into smaller ones.
The known issues left are (also see the updated readme):
Test plan (for @Foxushka only):