Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug CI #15

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Debug CI #15

wants to merge 5 commits into from

Conversation

ElisStaaf
Copy link

@ElisStaaf ElisStaaf commented Dec 21, 2024

.github/workflows/build-pass.yml

Typo. In the file this codeblock is executed:

{insignificant} && python3 smeltile.py

smeltile.py doesn't exist. Change to smeltfile.py.

You can't run a file that doesn't exist! The rule with the name of
"Build x86_64" was running this:

    {insignificant} && python3 smeltile.py

I looked trough the repo and couldn't find any "smeltile.py" file, but
the package "smelt3" has a configuration that requires a "smeltfile.py"
file, I also found a smeltfile.py file in the filesystem, so I went
ahead with that.
I believe there was a substantial issue in the "config/config.sh"
directory. Since all of the .asm files the config links the profile
files with are by default abiding to the "default" profiles rules.
Therefore I added a check to see if the profile is default. If so,
we exit.
haha, accidentally left debug message in.
Copy link
Owner

@GandelXIV GandelXIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for you contribution. There are some changes needed before we merge this.

This reverts commit 5ca85f6.

If I feel like it I'll *actually* fix the config but I'm
waaaay too tired rn, maybe I'll fix it later but idk :/
@ElisStaaf ElisStaaf changed the title Debug CI and config Debug CI Jan 9, 2025
@ElisStaaf
Copy link
Author

Yeah I reverted the config changes because I'm (believe it or not) lazy and tired. Maybe I'll come back in a few weeks with a config pull request but idk really

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants