-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug CI #15
Open
ElisStaaf
wants to merge
5
commits into
GandelXIV:master
Choose a base branch
from
ElisStaaf:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Debug CI #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can't run a file that doesn't exist! The rule with the name of "Build x86_64" was running this: {insignificant} && python3 smeltile.py I looked trough the repo and couldn't find any "smeltile.py" file, but the package "smelt3" has a configuration that requires a "smeltfile.py" file, I also found a smeltfile.py file in the filesystem, so I went ahead with that.
I believe there was a substantial issue in the "config/config.sh" directory. Since all of the .asm files the config links the profile files with are by default abiding to the "default" profiles rules. Therefore I added a check to see if the profile is default. If so, we exit.
haha, accidentally left debug message in.
GandelXIV
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for you contribution. There are some changes needed before we merge this.
Yeah I reverted the config changes because I'm (believe it or not) lazy and tired. Maybe I'll come back in a few weeks with a config pull request but idk really |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.github/workflows/build-pass.yml
Typo. In the file this codeblock is executed:
{insignificant} && python3 smeltile.py
smeltile.py
doesn't exist. Change tosmeltfile.py
.