Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following a little 🐛 into a 🐰 hole #952

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

carstingaxion
Copy link
Collaborator

This PR should help illustrating a problem; it's not (primarily meant to be merged)!


I was thinking about #528 and the long thread @mauteri had with Ed on the GatherPress slack, where they talked (among other things) about the default blocks that gets pre-populated when a New Event is created.

After a while .... I asked myself why GatherPress is not using the modal, provided by WP core since 5.8, that allows to select a starter-pattern for core/post-content. With an addition (I guess for WP 6.7) a user can now even disable this modal permanently for a given post_type, which would help GatherPress' work on #528.

I just wanted to try this fast, and if it could be made compatible with the new register_block_template() to create a UI for GatherPress starter-patterns for the post-content.


It took me a loooong while to find two weird 🐛s that prevented the modal from appearing.

Bildschirmaufzeichnung.vom.16.10.2024.11.04.03.mp4

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

Preview changes with Playground

You can preview the recent changes for PR#952 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

@carstingaxion carstingaxion added the bug Something isn't working label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant