PR 1: Centralize SideShift URLs to shared/config/sideshift.ts#318
Open
sr-857 wants to merge 2 commits intoGauravKarakoti:mainfrom
Open
PR 1: Centralize SideShift URLs to shared/config/sideshift.ts#318sr-857 wants to merge 2 commits intoGauravKarakoti:mainfrom
sr-857 wants to merge 2 commits intoGauravKarakoti:mainfrom
Conversation
Contributor
|
@sr-857 is attempting to deploy a commit to the Gaurav's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for swapsmithminiapp canceled.
|
Owner
|
Please resolve the merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 1: Centralize SideShift URLs (#271)
Technical Analysis
The codebase had hardcoded SideShift API endpoints and checkout URLs scattered across various frontend and backend files. This made it difficult to manage environment-specific configurations and increased the risk of inconsistent endpoint usage.
Proposed Solution
Centralize all SideShift-related URLs into a single configuration file in the shared directory. This ensures a "single source of truth" and simplifies updates to API versions or base URLs.
Changes
SIDESHIFT_CONFIGinshared/config/sideshift.ts.frontend/utils/sideshift-client.ts,bot/src/services/sideshift-client.ts, andfrontend/components/SwapConfirmation.tsxto use the centralized config.Verification