Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template for new Pull Request #47

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Conversation

smt5541
Copy link
Collaborator

@smt5541 smt5541 commented Jun 30, 2024

🛠 Changes being made

Give examples of the changes you've made in this pull request. Include an itemized list if you can.

  • Add template for new pull requests

🧠 Rationale behind the change

Why did you choose to make these changes?

  • Implement a self-review process for pull requests so that a submitter can ensure that the request meets quality guidelines for this project
  • Increase documentation for the rationale behind changes

Does this pull request resolve any open issues?

Nope

Were there any trade-offs you had to consider?

Ease of submission vs. verbosity: While this template adds more time to PR submission, it should help to ensure better quality in submitted code prior to review.

🧪 Testing

  • Have tests been added or updated for the changes introduced in this pull request?

N/A

  • Are the changes backwards compatible?

If the changes aren't backwards compatible, what other options were explored?

N/A

✨ Quality check

  • Are your changes free of any erroneous print statements, debuggers or other leftover code?

  • Has the README been updated to reflect the changes introduced (if applicable)?

💬 Additional comments

Feel free to add any further information below

@smt5541 smt5541 added the documentation Improvements or additions to documentation label Jun 30, 2024
@smt5541 smt5541 requested a review from Ge0rg3 June 30, 2024 22:40
@smt5541 smt5541 self-assigned this Jun 30, 2024
@Ge0rg3
Copy link
Owner

Ge0rg3 commented Jul 1, 2024

@smt5541 many thanks for all the recent changes, will go through thoroughly tomorrow 🙌

@Ge0rg3 Ge0rg3 merged commit 7cbc8a9 into master Jul 11, 2024
1 check passed
@Ge0rg3 Ge0rg3 deleted the dev/smt5541/pull_request_template branch July 11, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants