Skip to content

TeleOp fixes #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 21, 2024
Merged

TeleOp fixes #35

merged 3 commits into from
Dec 21, 2024

Conversation

penguinencounter
Copy link
Member

@penguinencounter penguinencounter commented Dec 20, 2024 •
edited
Loading

as requested in drive practice 12/19/2024, according to Bill

  • don't hold the driving lock while scoring specimen until necessary
  • "reset everything button"

@penguinencounter penguinencounter marked this pull request as ready for review December 20, 2024 18:16
@shuban-789 shuban-789 self-assigned this Dec 21, 2024
shuban-789
shuban-789 approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@shuban-789 shuban-789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduced cyclomatic complexity (Off line 355+), Improved reset code.

@penguinencounter penguinencounter merged commit 3f02f64 into master Dec 21, 2024
2 checks passed
@penguinencounter penguinencounter deleted the parallel-fixes-v1 branch December 21, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuban-789 shuban-789 shuban-789 approved these changes

Assignees

@shuban-789 shuban-789

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@penguinencounter @shuban-789